? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
31 Dec 2018

Pull Request for Issue #23400

Summary of Changes

As title says

Testing Instructions

Display Modules Manager

After patch

Client filter now displays.

screen shot 2018-12-31 at 08 14 57

screen shot 2018-12-31 at 08 14 37

avatar infograf768 infograf768 - open - 31 Dec 2018
avatar infograf768 infograf768 - change - 31 Dec 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Dec 2018
Category Administration com_modules
avatar richard67
richard67 - comment - 31 Dec 2018

I have tested this item successfully on 373e51f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23406.

avatar richard67 richard67 - test_item - 31 Dec 2018 - Tested successfully
avatar chmst
chmst - comment - 31 Dec 2018

I have tested this item successfully on 373e51f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23406.

avatar chmst
chmst - comment - 31 Dec 2018

I have tested this item successfully on 373e51f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23406.

avatar chmst chmst - test_item - 31 Dec 2018 - Tested successfully
avatar infograf768 infograf768 - change - 31 Dec 2018
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 31 Dec 2018

rtc. Thanks for testing.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23406.

avatar infograf768 infograf768 - change - 1 Jan 2019
Labels Added: ?
avatar infograf768 infograf768 - change - 4 Jan 2019
Labels Added: ?
avatar infograf768
infograf768 - comment - 4 Jan 2019

@wilsonge
Please merge as I have some other PRs concerning modules . One waiting ( #23289 ) and another one I have to do for a change missing in #23418

avatar wilsonge
wilsonge - comment - 5 Jan 2019

@SniperSister @zero-24 RIPS please. I'm not really sure how this happened as I reran this a second time so reproducible

http://ci.joomla.org/joomla/joomla-cms/13420
http://ci.joomla.org/joomla/joomla-cms/13418

But all i did was merge in 4.0 ?

avatar infograf768
infograf768 - comment - 6 Jan 2019

Looks OK to merge now @wilsonge

avatar wilsonge wilsonge - close - 6 Jan 2019
avatar wilsonge wilsonge - merge - 6 Jan 2019
avatar wilsonge wilsonge - change - 6 Jan 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-01-06 17:07:33
Closed_By wilsonge
avatar wilsonge
wilsonge - comment - 6 Jan 2019

Thanks :)

Add a Comment

Login with GitHub to post a comment