[#23362] - [4.0] Drop for loops
- Fixed in Code Base
- 30 Dec 2018
- Medium
- Build: 4.0-dev
- # 23362
- Diff
- dgrammatiko:4.0-dev-no-for-loops
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Fix various problems on:
- plg_joomlaupdate
- plg_extensionupdate
- plg_overridecheck
Testing Instructions
Apply patch and check if the three button work correctly
Expected result
Actual result
Problems:
- Usage of for loops
- No check before calling a fn on a document element (for whatever reason that element might not exist)
- ESLint
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository |
| Labels |
Added:
?
|
||
it not a problem
Actually there is: https://www.youtube.com/watch?v=Nzokr6Boeaw&list=PLNYkxOF6rcIAKIQFsNbV0JDws_G_bnNo9&index=12
complicated != problem
True but also for() is slower in new browsers and not really compatible with Joomla's CS: https://github.com/airbnb/javascript
but also for() is slower in new browsers
nope, it is faster than any loop
http://jsben.ch/gROW8
https://jsperf.com/for-vs-foreach/75
and not really compatible with Joomla's CS
okay got it
nope, it is faster than any loop
New browsers also means ES6+ code, not vars...
New browsers also means ES6+ code, not vars...
nope, it still faster https://jsperf.com/for-vs-foreach-vs-for-of/575
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-12-30 13:13:41 |
| Closed_By | ⇒ | wilsonge |
I think the readability trumps the small performance enhancement here. Although if we decide it practically doesn't work on scaling sites we can always come back to this :) This fixes various pieces of broken html so doing this for now
it not a problem, but I don't mind?