Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#23363] - [4.0] ESLint javascript scripts or fail

? ? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
28 Dec 2018

Pull Request for Issue # .

Summary of Changes

Add one more step on the drone setup to lint ES6 files (ES5 cannot be linted as there is no configuration/linter)

Testing Instructions

Check the drone output

Expected result

Files should not be committed if they don't adhere the js code style!!

Actual result

Documentation Changes Required

NO

avatar dgrammatiko dgrammatiko - open - 28 Dec 2018
avatar dgrammatiko dgrammatiko - change - 28 Dec 2018
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Dec 2018
Category ⇒ Unit Tests
avatar dgrammatiko dgrammatiko - change - 28 Dec 2018
Labels Added: ? ?
b0fce78 28 Dec 2018 avatar dgrammatiko grrr
c6d01cc 28 Dec 2018 avatar dgrammatiko nope
eeb2e84 28 Dec 2018 avatar dgrammatiko this
118642f 28 Dec 2018 avatar dgrammatiko undo
avatar dgrammatiko
dgrammatiko - comment - 28 Dec 2018

Tests rightfully fail for the javascript part:
screenshot 2018-12-28 at 13 11 38

@rdeutz please consider merging this and #23362 which solves the cs problems

avatar wilsonge
wilsonge - comment - 29 Dec 2018

This will fix the codestyle issues on their own #23381 when someone approves the security analysis

avatar dgrammatiko
dgrammatiko - comment - 29 Dec 2018

@wilsonge just merge
#23362 it got all the needed changes

avatar wilsonge wilsonge - change - 29 Dec 2018
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-12-29 10:46:38
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 29 Dec 2018
avatar wilsonge wilsonge - merge - 29 Dec 2018
avatar dgrammatiko
dgrammatiko - comment - 29 Dec 2018

Thanks

Add a Comment

Login with GitHub to post a comment