? ? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
26 Dec 2018

Summary of Changes

use namespaced class

Testing Instructions

code review
or action log work as before

avatar alikon alikon - open - 26 Dec 2018
avatar alikon alikon - change - 26 Dec 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Dec 2018
Category Front End Plugins
avatar Quy
Quy - comment - 26 Dec 2018

I have tested this item successfully on ab67f90


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23335.

avatar Quy Quy - test_item - 26 Dec 2018 - Tested successfully
avatar viocassel
viocassel - comment - 27 Dec 2018

I have tested this item successfully on ab67f90


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23335.

avatar viocassel viocassel - test_item - 27 Dec 2018 - Tested successfully
avatar Quy Quy - change - 27 Dec 2018
The description was changed
Status Pending Ready to Commit
avatar Quy
Quy - comment - 27 Dec 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23335.

avatar joomla-cms-bot joomla-cms-bot - edited - 27 Dec 2018
avatar joomla-cms-bot joomla-cms-bot - edited - 27 Dec 2018
avatar mbabker
mbabker - comment - 27 Dec 2018

Merge conflicts...

avatar alikon alikon - change - 27 Dec 2018
Labels Added: ? ?
avatar sandewt
sandewt - comment - 29 Dec 2018

Hi @alikon,

I looked at the code, and have a suggestion.

class PlgSystemActionLogs extends JPlugin
{

Could be:

use Joomla\CMS\Plugin\CMSPlugin;
...
class PlgSystemActionLogs extends CMSPlugin
{

Also apply to issue #23349 and #23350


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23335.
avatar mbabker mbabker - change - 5 Jan 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-01-05 16:16:24
Closed_By mbabker
avatar mbabker mbabker - close - 5 Jan 2019
avatar mbabker mbabker - merge - 5 Jan 2019

Add a Comment

Login with GitHub to post a comment