Feeling Lucky
?
?
[#23334] - [plugin][actionlog][joomla] use namespaced User/Factory
- Fixed in Code Base
- 5 Jan 2019
- Medium
- Build: staging
- # 23334
- Diff
- alikon:patch-109
User tests: Successful: Unsuccessful:
Summary of Changes
- use the namespaced
Userinstead ofJUser - use the namespaced
Factoryinstead ofJFactory
Testing Instructions
code review
or
test logout, login failure user save works as before
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Labels |
Added:
?
|
||
| Title |
|
||||||
sandewt
- comment
- 26 Dec 2018
Note:
The file plugins/actionlog/joomla/joomla.xml contains the following code:
</files>
<config /> // this code is wrong (line 15)
</extension>
Delete the tag in line 15. This is unnecessary.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23334.
alikon
- comment
- 26 Dec 2018
please do it in a separate PR
alikon
- comment
- 27 Dec 2018
@sandewt
for commemt #23334 (comment)
done
Quy
- comment
- 27 Dec 2018
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23334.
twister65
- comment
- 28 Dec 2018
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23334.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 28 Dec 2018
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23334.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-01-05 16:16:53 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
Ho @alikon,
The parent class is ActionLogPlugin, see the code of the file plugins/actionlog/joomla/joomla.php (1)
The file /administrator/components/com_actionlogs/libraries/actionlogplugin.php (2) contains the following code in line 60
So I think, you can move the namspace code
use Joomla\CMS\Factoryto that file (2) and change the code in line 60.Possible, there is more code to combine.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23334.