User tests: Successful: Unsuccessful:
User
instead of JUser
Factory
instead of JFactory
code review
or
test logout, login failure user save works as before
Status | New | ⇒ | Pending |
Category | ⇒ | Front End Plugins |
Labels |
Added:
?
|
Title |
|
Note:
The file plugins/actionlog/joomla/joomla.xml contains the following code:
</files>
<config /> // this code is wrong (line 15)
</extension>
Delete the tag in line 15. This is unnecessary.
please do it in a separate PR
@sandewt
for commemt #23334 (comment)
done
I have tested this item
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-01-05 16:16:53 |
Closed_By | ⇒ | mbabker | |
Labels |
Added:
?
|
Ho @alikon,
The parent class is ActionLogPlugin, see the code of the file plugins/actionlog/joomla/joomla.php (1)
The file /administrator/components/com_actionlogs/libraries/actionlogplugin.php (2) contains the following code in line 60
So I think, you can move the namspace code
use Joomla\CMS\Factory
to that file (2) and change the code in line 60.Possible, there is more code to combine.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23334.