? ? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
26 Dec 2018

Summary of Changes

  • use the namespaced User instead of JUser
  • use the namespaced Factory instead of JFactory

Testing Instructions

code review
or
test logout, login failure user save works as before

avatar alikon alikon - open - 26 Dec 2018
avatar alikon alikon - change - 26 Dec 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Dec 2018
Category Front End Plugins
avatar alikon alikon - change - 26 Dec 2018
Labels Added: ?
avatar alikon alikon - change - 26 Dec 2018
Title
[plugin][actionlog][joomla] use namespaced User
[plugin][actionlog][joomla] use namespaced User/Factory
avatar alikon alikon - edited - 26 Dec 2018
avatar alikon alikon - change - 26 Dec 2018
The description was changed
avatar alikon alikon - edited - 26 Dec 2018
avatar sandewt
sandewt - comment - 26 Dec 2018

Ho @alikon,

The parent class is ActionLogPlugin, see the code of the file plugins/actionlog/joomla/joomla.php (1)

class PlgActionlogJoomla extends ActionLogPlugin
{

The file /administrator/components/com_actionlogs/libraries/actionlogplugin.php (2) contains the following code in line 60

abstract class ActionLogPlugin extends JPlugin
{
...
$user = JFactory::getUser(); // line 60
...

So I think, you can move the namspace code use Joomla\CMS\Factory to that file (2) and change the code in line 60.

Possible, there is more code to combine.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23334.
avatar alikon
alikon - comment - 26 Dec 2018

see #23341

avatar sandewt
sandewt - comment - 26 Dec 2018

Note:

The file plugins/actionlog/joomla/joomla.xml contains the following code:

</files>
	<config /> // this code is wrong (line 15)
</extension>

Delete the tag in line 15. This is unnecessary.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23334.
avatar alikon
alikon - comment - 26 Dec 2018

please do it in a separate PR

avatar alikon
alikon - comment - 27 Dec 2018

@sandewt
for commemt #23334 (comment)
done

avatar Quy
Quy - comment - 27 Dec 2018

I have tested this item successfully on 78a568f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23334.

avatar Quy Quy - test_item - 27 Dec 2018 - Tested successfully
avatar twister65
twister65 - comment - 28 Dec 2018

I have tested this item successfully on 78a568f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23334.

avatar twister65 twister65 - test_item - 28 Dec 2018 - Tested successfully
avatar Quy Quy - change - 28 Dec 2018
Status Pending Ready to Commit
avatar Quy
Quy - comment - 28 Dec 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23334.

avatar mbabker mbabker - change - 5 Jan 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-01-05 16:16:53
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 5 Jan 2019
avatar mbabker mbabker - merge - 5 Jan 2019

Add a Comment

Login with GitHub to post a comment