? ? Pending

User tests: Successful: Unsuccessful:

avatar bembelimen
bembelimen
26 Dec 2018

Summary of Changes

This PR removes some unnecessary DB field aliases which break com_menu

Testing Instructions

  • Reinstall Joomla! 4
  • Apply sample data
  • Go to a menu

Expected result

Everything works

Actual result

Error: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '.`published`,`a`.`component_id`,`a`.`checked_out`,`a`.`checked_out_time`,`a`.`br' at line 1

avatar bembelimen bembelimen - open - 26 Dec 2018
avatar bembelimen bembelimen - change - 26 Dec 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Dec 2018
Category Administration com_menus
avatar infograf768 infograf768 - change - 26 Dec 2018
Title
Remove unnecessary DB field alias
[4.0] Remove unnecessary DB field alias
avatar infograf768 infograf768 - edited - 26 Dec 2018
avatar infograf768
infograf768 - comment - 26 Dec 2018

Please see #23293

avatar chmst
chmst - comment - 26 Dec 2018

The discussion in #23293 is about the $data. Removing the alias would at least heal at once the sql-error.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23333.

avatar chmst
chmst - comment - 26 Dec 2018

I have tested this item successfully on 89841cf


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23333.

avatar chmst
chmst - comment - 26 Dec 2018

I have tested this item successfully on 89841cf


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23333.

avatar chmst chmst - test_item - 26 Dec 2018 - Tested successfully
avatar infograf768
infograf768 - comment - 26 Dec 2018

I have tested this item successfully on 89841cf


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23333.

avatar infograf768 infograf768 - test_item - 26 Dec 2018 - Tested successfully
avatar Quy Quy - change - 26 Dec 2018
Status Pending Ready to Commit
avatar Quy
Quy - comment - 26 Dec 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23333.

avatar bembelimen bembelimen - change - 26 Dec 2018
Labels Added: ?
avatar wilsonge
wilsonge - comment - 26 Dec 2018

As @csthomas mentioned in #23293 this ends up with two published fields being retrieved. He submitted a fix to the framework which fixed the bug here. Please test #23344 instead

avatar wilsonge wilsonge - change - 26 Dec 2018
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2018-12-26 22:06:07
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 26 Dec 2018

Add a Comment

Login with GitHub to post a comment