[#23211] - Fix dateadd function for MS SQL Server
- Fixed in Code Base
- 5 Mar 2019
- Medium
- Build: staging
- # 23211
- Diff
- csthomas:mssql_dateadd
- Failure continuous-integration/drone/pr the build failed Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Fix an error at /administrator/index.php?option=com_privacy
An error has occurred.
102 [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]Incorrect syntax near '2018'.
See http://dev.mysql.com/doc/refman/5.1/en/date-and-time-functions.html#function_date-add
http://msdn.microsoft.com/en-us/library/ms186819.aspx
The first argument can not be a string (I mean the quoted string), the second must be an integer, the third argument is manually quoted in:
Testing Instructions
Code review
Expected result
Page /administrator/index.php?option=com_privacy will start working.
Actual result
Error
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | MS SQL Libraries |
| Labels |
Added:
?
|
||
| Category | MS SQL Libraries | ⇒ | MS SQL Libraries Unit Tests |
| Labels |
Added:
?
|
||
Since this is only related to the MSSQL database, I am asking for RTC
I run Win 7 Prof x64 ENU , IIS 7.5, PHP 5.69, MS-SQL-SRV-EXPRESS-2014, ODBC driver 11. All prerequisits are fullfilled. On start installation I get this error: Fehler [Microsoft][ODBC Driver 11 for SQL Server][SQL Server]Incorrect syntax near '59'. I checked this code token. The only thing that makes sense to me would be that passage in D:\webroot\Joomla\administrator\components\com_admin\sql\updates\postgresql\3.7.0-2016-08-22.sql
Code Start
INSERT INTO "#__extensions" ("extension_id", "name", "type", "element", "folder", "client_id", "enabled", "access", "protected", "manifest_cache", "params", "custom_data", "system_data", "checked_out", "checked_out_time", "ordering", "state") VALUES
(459, 'plg_editors-xtd_menu', 'plugin', 'menu', 'editors-xtd', 0, 1, 1, 0, '', '', '', '', 0, '1970-01-01 00:00:00', 0, 0);
Code End
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23211.
Hi supporters,
it may depend on odbc driver issues, but I guess it is the hard coded extensionID 459 that is not accepted. https://docs.microsoft.com/en-us/sql/connect/odbc/linux-mac/known-issues-in-this-version-of-the-driver?view=sql-server-2017 . These issues are the same and even worser for odbc driver 11.
Best regards
Axel Arnold Bangert - Herzogenrath 24.12.2018
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23211.
Is there any reason way this PR can not be merged?
This is just a fix in the dateAdd() method in sqlsrv query class.
Thank you - OK.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23211.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23211.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23211.
Status "Ready To Commit".
| Status | Pending | ⇒ | Ready to Commit |
Status "Ready To Commit".
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-03-05 11:39:33 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
thx
I have tested this item✅ successfully on a7a545b
code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23211.