Feeling Lucky
?
[#23210] - Fix sql queries in the update file for mssql
- Fixed in Code Base
- 19 Jan 2019
- Medium
- Build: staging
- # 23210
- Diff
- csthomas:mssql_update_fix
User tests: Successful: Unsuccessful:
Summary of Changes
Clean up the update files for the ms sql server.
- add missing
;at the end of sql query - replace quote
[]by double quote - add missing
SET IDENTITY_INSERT "..." ON; - replace
INSERT INTO ... SELECT ...byINSERT INTO ... VALUES (...) - add a white space after table name on line
CREATE TABLE ...to fix the error on backend -> extension -> manage -> database fix - replace a backtick "`" by double quote, the backtick does not work on the SQL Server.
- delete the default value before deleting the column:
3.9.0-2018-10-20.sql - remove useless
SET QUOTED_IDENTIFIER ON;
Testing Instructions
Code review.
Unit tests should pass.
I tested with postupdate.php.
Note: remove a line from code, which requires toolbar.php.
Expected result
Joomla on the SQL server should update correctly (from version 3.8.13).
Actual result
The Joomla update on the SQL server will fail.
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | MS SQL SQL Administration com_admin Libraries |
csthomas
- comment
- 5 Dec 2018
Since this is only related to the MSSQL database, I am asking for RTC
bonzani
- comment
- 18 Jan 2019
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23210.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 18 Jan 2019
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23210.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-01-19 11:45:48 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on d0ad452
review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23210.