[#23213] - Fix user session on mssql server and a new $db->quoteBinary() method
- Fixed in Code Base
- 17 Sep 2019
- Medium
- Build: staging
- # 23213
- Diff
- csthomas:quoteBinary
User tests: Successful: Unsuccessful:
Summary of Changes
From J3.9 the type of session_id column is varbinary(192) and it works OK for mysql and PostgreSQL database.
In the case of mssql, this column requires explicitly cast to binary value to work properly.
Testing Instructions
Test user session, login. logout, action logs, etc.
Probably no one will test it on mssql server, please test it at least on mysql.
Expected result
Joomla works (after installing or updating) on the mssql server.
Actual result
Joomla does not work (after installing or updating) on the mssql server.
Documentation Changes Required
Yes.
A new method $db->quoteBinary($data).
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries Postgresql MS SQL Front End Plugins |
shouldn't be ported on https://github.com/joomla-framework/database too ?
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23213.
shouldn't be ported on https://github.com/joomla-framework/database too ?
Yes. I will do it, I start here.
I'm closing it for now
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-12-21 21:29:35 |
| Closed_By | ⇒ | csthomas | |
| Labels |
Added:
?
|
||
| Status | Closed | ⇒ | New |
| Closed_Date | 2018-12-21 21:29:35 | ⇒ | |
| Closed_By | csthomas | ⇒ |
| Status | New | ⇒ | Pending |
I have tested this item
Works on mssql server 2017 (Linux)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23213.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23213.
I see only one test on an unkown database (alikon) and my test on mssql so we need one for mysql and one for pgsql before this is RTC.
| Status | Ready to Commit | ⇒ | Pending |
Status back on Pending.
my test was on postgresql
| Status | Pending | ⇒ | Ready to Commit |
So we need at least one on mysql
Is MariaDB OK?
Depends on the version
Am 20. Juli 2019 19:23:45 MESZ schrieb SharkyKZ notifications@github.com:
Is MariaDB OK?
--
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub:
#23213 (comment)
--
Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.
10.1.40 and 10.3.16.
A mysql 5.5 test would be great...
Thanks for adding binary encoding support to Joomla.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-09-17 16:23:58 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
on postgresql only😄