[#23140] - [4.0] RTL: Correcting Joomla Update version display in System CPanel badge and Joomla Update component
- Fixed in Code Base
- 26 Nov 2018
- Medium
- Build: 4.0-dev
- # 23140
- Diff
- infograf768:4.0-rtl-syspanel-jupdate
User tests: Successful: Unsuccessful:
Completing #23047 ++
Summary of Changes
Correcting RTL display of Joomla Update version in CPanel System as well as in the Joomla update component.
Correcting Extension version in Joomla Update component. That one required also to modify joomlaupdate default js file to change the order of version and 'Yes' when present
Basically we want to get for example:
4.0.0-alpha6-dev instead of alpha-dev-4.0.0 and align correctly the <span> concerned.
Testing Instructions
On last 4.0.0-dev branch
Modify libraries/src/Version.php
to const EXTRA_VERSION = 'alpha4-dev';
in order to get a database fix issue
Fix database.
Then in JoomlaUpdate Options choose Custom URL and add this link:
https://update.joomla.org/core/nightlies/next_major_list.xml
Install Persian language and set admin language to Persian.
Requires using npm ci to test.
Before patch
After patch
If no update available
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_cpanel com_joomlaupdate Templates (admin) JavaScript Repository |
| Labels |
Added:
?
|
||
Fixes also display of version number of extensions like e.g. patchtester 3.0.0-beta4 in the pre-update check with RTL language.
In opposite to screenshot above, when using Persioan language during my test, the head line of the pre-update check was in English and already with correct version number in the "before patch" scenario. Maybe we used different versions of the Persioan language?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23140.
@richard67
the string concerned in the persian 3.x lang pack contains some span html formatting (as all 3.x lang packs). i modified it here, which could explain.
thanks for testing!
@infograf768 Welcome. Do you think you could have a look on my PR #23055 and maybe test or review or both?
on it
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-11-26 15:43:53 |
| Closed_By | ⇒ | wilsonge |
Thanks JM!
I have tested this item✅ successfully on 8db146a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23140.