? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
22 Nov 2018

Pull Request related to Issue #21445 .

Summary of Changes

Don't put fields through getColumnAlias() before passing them to hasField(). It already does that.

Testing Instructions

Code review.

CC @wilsonge @alikon.

avatar SharkyKZ SharkyKZ - open - 22 Nov 2018
avatar SharkyKZ SharkyKZ - change - 22 Nov 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Nov 2018
Category Libraries
avatar SharkyKZ SharkyKZ - change - 22 Nov 2018
The description was changed
avatar SharkyKZ SharkyKZ - edited - 22 Nov 2018
avatar SharkyKZ SharkyKZ - change - 22 Nov 2018
Labels Added: ?
9110334 22 Nov 2018 avatar SharkyKZ CS
avatar wilsonge wilsonge - change - 30 Nov 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-11-30 15:12:08
Closed_By wilsonge
avatar wilsonge wilsonge - close - 30 Nov 2018
avatar wilsonge wilsonge - merge - 30 Nov 2018
avatar wilsonge
wilsonge - comment - 30 Nov 2018

Thanks!

avatar infograf768
infograf768 - comment - 1 Dec 2018

@SharkyKZ @wilsonge
I have an error after this patch when close or save and close a plugin
Call to undefined method Joomla\Component\Plugins\Administrator\Model\PluginModel::getColumnAlias()

I think (as I tested here) that
$checkedOutField = $this->getColumnAlias('checked_out');
is wrong
and should be changed to
$checkedOutField = $table->getColumnAlias('checked_out');

in libraries/src/MVC/Model/FormModel.php line 107

avatar SharkyKZ
SharkyKZ - comment - 1 Dec 2018

@infograf768 Thanks, it's a typo. Test #23220 please.

Add a Comment

Login with GitHub to post a comment