? Pending

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
17 Nov 2018

Pull Request for Issue #23039

Summary of Changes

Fixes the broken install from web tab on the (what appears to be presently untested/unreviewed) extension manager's install view.

Notable changes:

  • Removes custom loading element in favor of the Joomla.loadingLayer script (as specified in #19429)
  • Removes the requirement for JSONP in the calls to the remote server as CORS has now been implemented
  • Refactors the script initialization to remove the jQuery and Bootstrap dependencies and work with the page's CEs

Testing Instructions

On an environment where you can run npm, apply this patch and recompile the UI elements, then go to the extension manager and ensure the install from web UI goes further than the "Loading..." initial display.

Expected result

IFW actually works

Actual result

IFW has been broken for approximately 3 months (since the conversion of the install view of the extension manager to use CEs)

Documentation Changes Required

Doubtful any documentation change can fix a workflow issue

avatar mbabker mbabker - open - 17 Nov 2018
avatar mbabker mbabker - change - 17 Nov 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Nov 2018
Category JavaScript Repository
avatar mbabker mbabker - change - 17 Nov 2018
Labels Added: ?
avatar ghazal
ghazal - comment - 18 Nov 2018

I have tested this item successfully on 328e570


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23104.

avatar ghazal ghazal - test_item - 18 Nov 2018 - Tested successfully
avatar wilsonge
wilsonge - comment - 21 Nov 2018

I have tested this item successfully on c014256

Loading screen only before patch. IFW loads after applying patch.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23104.

avatar wilsonge wilsonge - test_item - 21 Nov 2018 - Tested successfully
avatar wilsonge wilsonge - change - 22 Nov 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-11-22 11:12:52
Closed_By wilsonge
avatar wilsonge wilsonge - close - 22 Nov 2018
avatar wilsonge wilsonge - merge - 22 Nov 2018
avatar wilsonge
wilsonge - comment - 22 Nov 2018

Thanks!

Add a Comment

Login with GitHub to post a comment