?
avatar acvmultimedia
acvmultimedia
17 Nov 2018

Steps to reproduce the issue

Administrator first page "control panel".

Expected result

The panel control menu should have a change in 2 icons and I suggest putting a slight green background color.

Actual result

screen shot 2018-11-17 at 11 51 00

System information (as much as possible)

Additional comments

avatar acvmultimedia acvmultimedia - open - 17 Nov 2018
avatar joomla-cms-bot joomla-cms-bot - labeled - 17 Nov 2018
avatar infograf768
infograf768 - comment - 18 Nov 2018

This rather easy to do.
But first please lets test and merge #23095

avatar hardik-codes
hardik-codes - comment - 29 Jan 2019

@infograf768 may I go ahead with this issue ?

avatar Quy
Quy - comment - 29 Jan 2019

@hardik-codes Joomla! is is community developed software. You do not need to get permission to submit pull requests. Go for it!

avatar hardik-codes
hardik-codes - comment - 29 Jan 2019

OK
@Quy could you help me with the files to get started ?

avatar hardik-codes
hardik-codes - comment - 31 Jan 2019

@Infograf and @Quy which 2 icons need to be changed ?

avatar Quy
Quy - comment - 31 Jan 2019

Sorry I don't know. @acvmultimedia please advise.

avatar infograf768
infograf768 - comment - 1 Feb 2019

The background can be modified by changing
https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/templates/atum/scss/blocks/_quickicons.scss#L60-L62

to

    &.success {
      color: var(--success);
      background: #d9e6d9;
      box-shadow: $quickicon-box-shadow-success;
    }

to get, after running npm ci

screen shot 2019-02-01 at 10 16 35

If we want to change the icons, they will be changed globally, i.e. whatever the status.
Example 'image' => 'fa fa-file-o', in:
https://github.com/joomla/joomla-cms/blob/4.0-dev/plugins/quickicon/overridecheck/overridecheck.php#L87-L96

can be modifed to
'image' => 'fa fa-file,
similar for Extensions update to obtain
screen shot 2019-02-01 at 10 25 06

avatar acvmultimedia
acvmultimedia - comment - 1 Feb 2019

Thanks @infograf768 that is the idea, I am a designer and no programer can you change it for me in Joomla! 4 core?

avatar acvmultimedia
acvmultimedia - comment - 1 Feb 2019

OK, for green background #e9ffe5 and icons better with interior filled with color (star and document).

avatar infograf768
infograf768 - comment - 1 Feb 2019

background should correspond to the color we use for Success Messages, that's why I used
background: #d9e6d9; which is the same as used in alert.
No usee to introduce new colors imho

avatar acvmultimedia
acvmultimedia - comment - 1 Feb 2019

Sorry, it´s OK #d9e6d9 thanks @infograf768

avatar infograf768
infograf768 - comment - 1 Feb 2019

Will make PR with a new $colors variable

avatar hardik-codes
hardik-codes - comment - 1 Feb 2019

@infograf768 please may I go ahead with this issue

avatar infograf768
infograf768 - comment - 1 Feb 2019

Sorry, already done
#23733

Please test. Closing as we have a patch.

avatar infograf768
infograf768 - comment - 1 Feb 2019

@hardik-codes
There is a quite simple way to find out where a code has to be modified:
Use web developper tools ( I use Firefox ) and inspect code.
In 4.0, a specific css may come from different types of scss.
To test I often put debug system on to test stuff on non-minified files.
Then search how this code is produced. I use often BBEdit multifiles search.

avatar acvmultimedia
acvmultimedia - comment - 1 Feb 2019

OK I will close Issue?

avatar infograf768 infograf768 - change - 1 Feb 2019
Status New Closed
Closed_Date 0000-00-00 00:00:00 2019-02-01 11:13:56
Closed_By infograf768
avatar infograf768 infograf768 - close - 1 Feb 2019
avatar infograf768
infograf768 - comment - 1 Feb 2019

done

Add a Comment

Login with GitHub to post a comment