? ? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
16 Nov 2018

Closes #22963

Summary of Changes

Added missing CSS for the eye and eye close icons (hide/show password icon) and set correct cursor

Testing Instructions

checkout 4.0-dev
apply pr
npm ci
npm run build:css (just in case)
clear browser cache
load installation page, enter site name, click Setup Login data
On this next page note the new eye icon - click it

Expected result

screenshot 2018-11-16 at 12 07 29

Actual result

screenshot 2018-11-16 at 12 07 29

Documentation Changes Required

None

avatar PhilETaylor PhilETaylor - open - 16 Nov 2018
avatar PhilETaylor PhilETaylor - change - 16 Nov 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Nov 2018
Category Installation
avatar PhilETaylor PhilETaylor - change - 16 Nov 2018
Labels Added: ?
3d32538 16 Nov 2018 avatar PhilETaylor cs
avatar richard67
richard67 - comment - 17 Nov 2018

I have tested this item successfully on 85235d8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23097.

avatar richard67 richard67 - test_item - 17 Nov 2018 - Tested successfully
avatar richard67
richard67 - comment - 24 Nov 2018

I have tested this item successfully on 29aa3e2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23097.

avatar richard67 richard67 - test_item - 24 Nov 2018 - Tested successfully
avatar infograf768
infograf768 - comment - 25 Nov 2018

I have tested this item successfully on 29aa3e2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23097.

avatar infograf768 infograf768 - test_item - 25 Nov 2018 - Tested successfully
avatar infograf768 infograf768 - change - 25 Nov 2018
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 25 Nov 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23097.
avatar infograf768 infograf768 - change - 25 Nov 2018
Labels Added: ?
avatar wilsonge wilsonge - change - 26 Nov 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-11-26 18:22:59
Closed_By wilsonge
avatar wilsonge wilsonge - close - 26 Nov 2018
avatar wilsonge wilsonge - merge - 26 Nov 2018
avatar wilsonge
wilsonge - comment - 26 Nov 2018

Thanks!

Add a Comment

Login with GitHub to post a comment