? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
16 Nov 2018

Pull Request for Issue #23064.

Hard to replicate the issue in #23064, if I fake the params to get the layout, - this does indeed fix it

<p class="feed-readmore"><a target="_blank" href ="/index.php">Read More ...</a></p>]]></description>

becomes

<p class="feed-readmore"><a target="_blank" href ="https://0.0.0.0/index.php">Read More ...</a></p>]]></description>

see: #23064

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
2.00

avatar PhilETaylor PhilETaylor - open - 16 Nov 2018
avatar PhilETaylor PhilETaylor - change - 16 Nov 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Nov 2018
Category Front End com_content
avatar PhilETaylor PhilETaylor - change - 16 Nov 2018
The description was changed
avatar PhilETaylor PhilETaylor - edited - 16 Nov 2018
avatar PhilETaylor PhilETaylor - change - 16 Nov 2018
The description was changed
avatar PhilETaylor PhilETaylor - edited - 16 Nov 2018
avatar SharkyKZ
SharkyKZ - comment - 16 Nov 2018

This forces HTTPS links.

avatar PhilETaylor
PhilETaylor - comment - 16 Nov 2018

ah ok - im on the school run so cant change for the moment

avatar ivankomlev
ivankomlev - comment - 16 Nov 2018

I have tested this item āœ… successfully on d5a2358


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23098.

avatar ivankomlev ivankomlev - test_item - 16 Nov 2018 - Tested successfully
avatar pabloarias
pabloarias - comment - 16 Nov 2018

I have tested this item āœ… successfully on d5a2358

Before patch, URLs were relatives and the Read more links fails. After the patch the URLs are absolute and are working fine.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23098.

avatar pabloarias pabloarias - test_item - 16 Nov 2018 - Tested successfully
avatar PhilETaylor
PhilETaylor - comment - 16 Nov 2018

DO NOT MEEGE YET all links come with https prefix even if site is not on ssl

Will fix next time Iā€™m at my desk

avatar PhilETaylor PhilETaylor - change - 10 Feb 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-02-10 21:35:53
Closed_By PhilETaylor
Labels Added: ?
avatar PhilETaylor PhilETaylor - close - 10 Feb 2019
avatar nzyeehaa
nzyeehaa - comment - 31 Oct 2019

@PhilETaylor please re-open - PR not integrated yet - adjustments below

RE: issue #23064 RSS READMORE link is RELATIVE

@pabloarias @joomlaboat
Please test the following... (notes at bottom)

joomla-cms/components/com_content/views/category/view.feed.php

replace...

// URL link to article
$link = JRoute::_(ContentHelperRoute::getArticleRoute($item->slug, $item->catid, $item->language));

with...

// URL link to article
$link = JRoute::_((ContentHelperRoute::getArticleRoute($item->slug, $item->catid, $item-language)), true, 2);

NOTES:
JRoute::_ options show ($url, $xhtml, $ssl)
$ssl options are normally...
-1 = force unsecure HTTP
0 = as passed (but this leaves relative link)
1 = force secure HTTPS

but when i input
2 = link shows as relative + unsecure then I leave .htaccess to redirect to HTTPS

PLEASE NOTE:
code is updated(had missing brackets)
NONE of these options respect Global Configuration -> force HTTPS
this probably requires further investigation, but my brief look suggests J4 is probably getting closer - this just saves me repairing broken sites every time there is an update

avatar nzyeehaa
nzyeehaa - comment - 9 Nov 2020

this still hasnt been fixed as of 3.9.22

avatar SharkyKZ
SharkyKZ - comment - 9 Nov 2020

@nzyeehaa Thanks for reminding. Please test PR #31369.

avatar nzyeehaa
nzyeehaa - comment - 18 Apr 2021

fixed

Add a Comment

Login with GitHub to post a comment