? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
16 Nov 2018

Closes #23074

Summary of Changes

If mail is enabled in Joomla config, but we were unable to send the email, the request is created, but the error message states that the request was not created.

There is no point in creating a request if we cannot send the email - this is why mailing has to be enabled. If your mail settings are wrong, the mail cannot be sent, and therefore we should remove the request and inform the user correctly.

Testing Instructions

Default 3.9.0 installation with this PR.
Create a "Create Request" Menu item using Privacy -> Create Request menu type
in Joomla Global Config set:

  • Send Mail = Yes
  • Mailer = SMTP
  • SMTP HOST = NO_SUCH_SERVER
    Login to frontend of the site
    Click Create Request
    Enter email address
    Click submit

Expected result

screenshot 2018-11-16 at 11 37 54

and NO ROW left in #__privacy_requests

Actual result

(note this error was NOT generated with the above testing instructions, for this one you need to disable mail in php which is harder than the above testing instructions.)

48470377-2ccf9d00-e7e9-11e8-8c94-0837f45200cd

and ROW left in #__privacy_requests even though the error says no request was made.

Documentation Changes Required

None

avatar PhilETaylor PhilETaylor - open - 16 Nov 2018
avatar PhilETaylor PhilETaylor - change - 16 Nov 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Nov 2018
Category Front End
148a19d 16 Nov 2018 avatar PhilETaylor cs
avatar PhilETaylor PhilETaylor - change - 16 Nov 2018
Labels Added: ?
avatar PhilETaylor
PhilETaylor - comment - 16 Nov 2018

@mbabker please take a look ;-) dont want to ruin your amazing work :)

avatar mbabker
mbabker - comment - 16 Nov 2018

I don't support this. It was intended to have a "resend email" feature in the admin before I burned out on this work. A request should not be removed simply because the user notification email does not get sent out.

I'm also not comfortable having an "easy to use" PHP API that encourages deleting requests. The workflow is designed so that these should NOT be deleted.

Lastly, this does also make it possible for a request to be invalidated/deleted if for whatever reason the Table API fails to load the request record to be able to build the action log message.

avatar PhilETaylor
PhilETaylor - comment - 16 Nov 2018

ok then please visit #23074 and comment on the issue this was trying to resolve: #23074

avatar PhilETaylor PhilETaylor - change - 16 Nov 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-11-16 13:18:44
Closed_By PhilETaylor
avatar PhilETaylor PhilETaylor - close - 16 Nov 2018

Add a Comment

Login with GitHub to post a comment