[#23095] - [4.0] RFC Quickicons Joomla and Extensions updates
- Fixed in Code Base
- 28 Nov 2018
- Medium
- Build: 4.0-dev
- # 23095
- Diff
- infograf768:4.0-quickicon-all-updates
User tests: Successful: Unsuccessful:
Replaces and complete #23061 (for what concerns Joomla Update).
Implement NOTE in #23061 (comment)
Summary of Changes
- Adding Joomla Version
- Change icon color to
warningwhen an update is available asdangeris used in case of error. - Place the
Update NowandView Updatesbuttons to the bottom right of the Message, centering the rest of the message. - Adapt Atum CSS concerned to RTL, including the
joomla-alert - Correct unnecessary
,and:in the language strings - Correct
Text::scripttofalseby default to let single quotes in language strings to display unescaped instead of\'
Testing Instructions
To test on 4.0-dev branch
Concerning joomlaupdate:
Modify version.php line 63 to const EXTRA_VERSION = 'alpha4-dev';
Go to database and Fix database.
Then in JoomlaUpdate Options choose Custom URL and add this link (Thanks Tobias) :
https://update.joomla.org/core/nightlies/next_major_list.xml
Save Options.
Display Control Panel.
Concerning extensions update:
Install an older language pack in order to get a warning for an update.
fr-FR_joomla_lang_full_3.9.0v1.zip
in both cases, test also RTL by installing and switching to Persian language.
Test before patch, then run npm ci
Expected result
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Templates (admin) JavaScript Repository Front End Plugins |
| Labels |
Added:
J4 Issue
?
?
|
||
Note: furher PR will correct RTL for the J version
@richard67
I need to update this now for RTL version but also for another js issue.
Please test again after I updated.
@richard67
OK, you can test again now.
The modifications concern the version in RTL (Test by using Persian), as well as showing the Joomlaupdate Quickicon in Green when there is no Update available.
@infograf768 I don't see any difference in the Persian screenshots. What has changed?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23095.
formerly (see on top), the version read alpha6-dev etc.
it now displays correctly 4.0.0-alpha etc, i.e. the version is ltr in a rtl lang string
I see now.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23095.
@infograf768 Now I tested and it seemed ok. But after switching back the Joomla update channel to "Default" and changing back Version.php and fixing the database, I get a javascript error from the Joomla update check, and the update check does not finish:
Reverting the PR and running "npm ci" does not fix that, so I am not sure if related to this PR or not.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23095.
@infograf768 I've started again with clean 4.0-dev, installed patch tester, applied your patch, run "npm ci", switched on system debugging in global settings so uncompressed js is used.
The js error is in jupdatecheck.js, row 32, column 11, which is statement "if (updateInfo.version === options.version) {", and sais "TypeError: updateInfo is undefined".
This seems to come from your last change.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23095.
@infograf768 It seems that the "if (updateInfoList.length === 0) {" you've removed with your last change was not there for no reason.
on ipad now. will look later. the issue was to get the ‘success’ class instead of only ‘pulse’. we may have to define as var and empty the ‘updateinfo.version’ first.
@infograf768 Can you check if my PR infograf768#50 against your branch is the right thing to correct it and get what you want with the success class? Unfortunately I made a mistake in title of the commit so it contains "warning" instead of "success", which is misleading. So you better just check it and if ok do the same change yourself.
@infograf768 I've just tested my changes from infograf768#50, applied to this PR here, and it works. Javascript error is gone, and Joomla Update is green.
Thanks @richard67
I mark your test Ok again.
Yes, I've just tested again, works all well.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23095.
RTL can now be tested fully as alert has been updated.
One has to use present 4.0.0-dev branch, patch and run npm ci.
Result:
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23095.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-11-28 11:45:18 |
| Closed_By | ⇒ | wilsonge |
Thanks JM!
and @richard67 ;)
I have tested this item✅ successfully on a419403
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23095.