Feeling Lucky
?
[#23035] - [4.0] Remove obsolete template color handling from Cassiopeia offline.php
- Fixed in Code Base
- 12 Nov 2018
- Medium
- Build: 4.0-dev
- # 23035
- Diff
- richard67:cassiopeia-offline-remove-template-color
- Failure continuous-integration/drone/pr the build failed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
- Error continuous-integration/appveyor/pr AppVeyor build cancelled Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # N.A.
Summary of Changes
Remove handling of not existing parameter "templateColor" from offline page of Cassiopeia template.
It seems to be a remainder from copying the offline.php from Joomla 3 (staging).
Testing Instructions
- Code review: Check that in no other file of the Cassiopeia template than the offline.php is any use of parameter "templateColor", and check that this PR removes this.
- In addition to test 1, check that in the Cassiopeia template style settings there is nowhere any option related to template color.
Expected result
No use of not existing parameter "templateColor" in any file of the Casssiopeia template.
Actual result
Not existing parameter "templateColor" is used in file "offline.php" of the Casssiopeia template.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) |
richard67
- comment
- 11 Nov 2018
Now the issue tracker shows wrong status for Appveyor, it seems to be confused from my just closed other PR.
I hope maintainers will not be confused by that.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23035.
| Title |
|
||||||
| Title |
|
||||||
Quy
- comment
- 11 Nov 2018
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23035.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 11 Nov 2018
rtc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23035.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-11-12 08:35:38 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
?
|
||
laoneo
- comment
- 12 Nov 2018
Thanks
I have tested this item✅ successfully on c65f215
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23035.