Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#23034] - [4.0] Remove obsolete template color handling from Cassiopeia offline.php - 1st try

? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
11 Nov 2018

Pull Request for Issue # N.A.

Summary of Changes

Remove handling of not existing parameter "templateColor" from offline page of Cassiopeia template.

It seems to be a remainder from copying the offline.php from Joomla 3 (staging).

Testing Instructions

  1. Code review: Check that in no other file of the Cassiopeia template than the offline.php is any use of parameter "templateColor", and check that this PR removes this.
  2. In addition to test 1, check that in the Cassiopeia template style settings there is nowhere any option related to template color.

Expected result

No use of not existing parameter "templateColor" in any file of the Casssiopeia template.

Actual result

Not existing parameter "templateColor" is used in file "offline.php" of the Casssiopeia template.

Documentation Changes Required

None.

avatar richard67 richard67 - open - 11 Nov 2018
avatar richard67 richard67 - change - 11 Nov 2018
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Nov 2018
Category ⇒ Front End Templates (site)
avatar richard67 richard67 - change - 11 Nov 2018
Title
…
Remove template color handling from Cassiopeia offline.php
[4.0] Remove obsolete template color handling from Cassiopeia offline.php
avatar richard67 richard67 - edited - 11 Nov 2018
avatar richard67 richard67 - change - 11 Nov 2018
Easy No ⇒ Yes
avatar SharkyKZ
SharkyKZ - comment - 11 Nov 2018

I have tested this item ✅ successfully on c65f215

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23034.

avatar richard67
richard67 - comment - 11 Nov 2018

Hmm, selecting "Easy test" in the issue btracker made this PR disappear from the issue tracker. I close it and make a new, identical one.

avatar richard67 richard67 - change - 11 Nov 2018
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-11-11 12:25:45
Closed_By ⇒ richard67
Labels Added: ?
avatar richard67 richard67 - close - 11 Nov 2018
avatar SharkyKZ SharkyKZ - test_item - 11 Nov 2018 - Tested successfully
avatar richard67
richard67 - comment - 11 Nov 2018

Reopening.

avatar richard67 richard67 - change - 11 Nov 2018
Status Closed ⇒ New
Closed_Date 2018-11-11 12:25:45 ⇒
Closed_By richard67 ⇒
avatar richard67 richard67 - change - 11 Nov 2018
Status New ⇒ Pending
avatar richard67 richard67 - reopen - 11 Nov 2018
avatar richard67
richard67 - comment - 11 Nov 2018

Hmm, selecting "Easy test" in the issue btracker made this PR disappear from the issue tracker. I close it and make a new, identical one. @SharkyKZ can you test the new one again? You should see it in a minute in the tracker.

avatar richard67 richard67 - close - 11 Nov 2018
avatar richard67 richard67 - change - 11 Nov 2018
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-11-11 12:27:49
Closed_By ⇒ richard67
avatar SharkyKZ
SharkyKZ - comment - 11 Nov 2018

OK, but this one appeared fine on the Issue Tracker.

avatar richard67
richard67 - comment - 11 Nov 2018

@SharkyKZ Here it dieappeared and did not appear again. New one is #23035 .

avatar richard67 richard67 - change - 11 Nov 2018
Title
…
[4.0] Remove obsolete template color handling from Cassiopeia offline.php
[4.0] Remove obsolete template color handling from Cassiopeia offline.php - 1st try
avatar richard67 richard67 - edited - 11 Nov 2018

Add a Comment

Login with GitHub to post a comment