? J4 Issue ?
avatar wilsonge
wilsonge
11 Nov 2018

As part of the custom fields integration we've had to make a reasonably nasty hack to hide errors https://github.com/joomla/joomla-cms/pull/22263/files#diff-1012a2e43c80bf48fceac68dbb3552c7R315

I want to spend some time before final release working out if there is a better way of working around custom elements/reworking the internals of custom fields or if this is the best we can do

avatar wilsonge wilsonge - open - 11 Nov 2018
avatar joomla-cms-bot joomla-cms-bot - change - 11 Nov 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 11 Nov 2018
avatar wilsonge wilsonge - change - 11 Nov 2018
Labels Added: ?
avatar wilsonge wilsonge - labeled - 11 Nov 2018
avatar dgrammatiko
dgrammatiko - comment - 11 Nov 2018

@wilsonge don't waste your time on this, the solutions is already here: #22491

avatar wilsonge
wilsonge - comment - 11 Nov 2018

That looks like a good start but you’re not changing the DomDocument code there which is the issue in the choices PR

avatar dgrammatiko
dgrammatiko - comment - 11 Nov 2018

I don't think you need that with my approach, check what the custom fields plugin is returning and also how that is used by the category field. (the idea is that custom fields should do their part on the form prepare, therefore, no DOMDocument need)

avatar dgrammatiko
dgrammatiko - comment - 12 Nov 2018

@wilsonge if you have to use DOMDocument I'll suggest adding https://github.com/ivopetkov/html5-dom-document-php. The native DOMDocument doesn't even understand HTML5 tags like header, main, footer (hot garbage...)

avatar franz-wohlkoenig franz-wohlkoenig - change - 4 Mar 2019
Status New Discussion
avatar joomla-cms-bot joomla-cms-bot - unlabeled - 4 Mar 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 28 Mar 2019
Category Code style com_fields
avatar franz-wohlkoenig franz-wohlkoenig - unlabeled - 4 Apr 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 4 Apr 2019
Labels Added: J3 Issue
avatar franz-wohlkoenig franz-wohlkoenig - labeled - 4 Apr 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 7 Apr 2019
Labels Added: ?
avatar franz-wohlkoenig franz-wohlkoenig - labeled - 7 Apr 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 9 Apr 2019
Category Code style com_fields com_fields
avatar wilsonge wilsonge - change - 10 Apr 2019
Labels Added: J4 Issue
Removed: J3 Issue
avatar wilsonge wilsonge - unlabeled - 10 Apr 2019
avatar wilsonge wilsonge - labeled - 10 Apr 2019
avatar wilsonge wilsonge - change - 17 Feb 2020
Labels Added: ?
avatar wilsonge wilsonge - labeled - 17 Feb 2020
avatar Fedik
Fedik - comment - 3 Aug 2020

please test this #30268

avatar alikon alikon - change - 3 Aug 2020
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2020-08-03 16:22:22
Closed_By alikon
Labels Added: ?
Removed: ?
avatar alikon alikon - close - 3 Aug 2020
avatar alikon
alikon - comment - 3 Aug 2020

closing as we have a PR

avatar wilsonge wilsonge - change - 16 Sep 2020
Labels Removed: ?
avatar wilsonge wilsonge - unlabeled - 16 Sep 2020

Add a Comment

Login with GitHub to post a comment