[#23036] - Custom Elements integration with Custom Fields needs work
- Closed
- 3 Aug 2020
- Medium
- Build: master
- # 23036
As part of the custom fields integration we've had to make a reasonably nasty hack to hide errors https://github.com/joomla/joomla-cms/pull/22263/files#diff-1012a2e43c80bf48fceac68dbb3552c7R315
I want to spend some time before final release working out if there is a better way of working around custom elements/reworking the internals of custom fields or if this is the best we can do
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
That looks like a good start but you’re not changing the DomDocument code there which is the issue in the choices PR
I don't think you need that with my approach, check what the custom fields plugin is returning and also how that is used by the category field. (the idea is that custom fields should do their part on the form prepare, therefore, no DOMDocument need)
@wilsonge if you have to use DOMDocument I'll suggest adding https://github.com/ivopetkov/html5-dom-document-php. The native DOMDocument doesn't even understand HTML5 tags like header, main, footer (hot garbage...)
franz-wohlkoenig
- | Status | New | ⇒ | Discussion |
| Category | ⇒ | Code style com_fields |
| Labels |
Added:
J3 Issue
|
||
| Labels |
Added:
?
|
||
| Category | Code style com_fields | ⇒ | com_fields |
| Labels |
Added:
J4 Issue
Removed: J3 Issue |
||
| Labels |
Added:
?
|
||
| Status | Discussion | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-08-03 16:22:22 |
| Closed_By | ⇒ | alikon | |
| Labels |
Added:
?
Removed: ? |
||
closing as we have a PR
| Labels |
Removed:
?
|
||
@wilsonge don't waste your time on this, the solutions is already here: #22491