J4 Issue ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
8 Nov 2018

Testing instructions

Install an older language pack, for example:
fr-FR_joomla_lang_full_3.9.0v2.zip

Display Control Panel
An extension update is proposed.

Note: process would be similar for Joomla Update

Before patch

message is not translated.
A supplementary useless error info message is displayed.

screen shot 2018-11-08 at 09 51 52

After patch

screen shot 2018-11-08 at 10 06 45

Note

Needs running npm ci

avatar infograf768 infograf768 - open - 8 Nov 2018
avatar infograf768 infograf768 - change - 8 Nov 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Nov 2018
Category JavaScript Repository Front End Plugins
avatar infograf768 infograf768 - change - 8 Nov 2018
The description was changed
avatar infograf768 infograf768 - edited - 8 Nov 2018
avatar PhilETaylor
PhilETaylor - comment - 9 Nov 2018

Before applying patch I get no backgrounds:

screenshot 2018-11-09 at 15 08 02

avatar PhilETaylor
PhilETaylor - comment - 9 Nov 2018

After patch I got: (no error part this time, ignoring the background issue)

screenshot 2018-11-09 at 15 15 49

avatar PhilETaylor
PhilETaylor - comment - 9 Nov 2018

I have tested this item successfully on 661ee09

as per notes above


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22971.

avatar PhilETaylor PhilETaylor - test_item - 9 Nov 2018 - Tested successfully
avatar infograf768
infograf768 - comment - 9 Nov 2018

The fact that you get no background is weird.
I guess we can change here the Message to a Warning to get the right colour. Not sure. Would have to test.

avatar PhilETaylor
PhilETaylor - comment - 9 Nov 2018

Im just about to do the school run - so no time to dig deeper - logged issue so it doesnt get lost

avatar infograf768
infograf768 - comment - 9 Nov 2018

let’s wait abit here asit lookks like joomla.render.messages is confusing.

avatar PhilETaylor
PhilETaylor - comment - 9 Nov 2018

Yup - see my other pr comment

I’ve had to do the school run and now sat outside in the rain for an hour at gymnastics with her so could not continue to dig deeper and resolve this right away like the other one

Looks like the messages renderer has multiple issues to resolve :-(

——
Sent from my iPhone - sorry - if needed I’ll send longer email from my desk later.
——

On 9 Nov 2018, at 17:27, infograf768 notifications@github.com wrote:

let’s wait abit here asit lookks like joomla.render.messages is confusing.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

avatar PhilETaylor
PhilETaylor - comment - 9 Nov 2018

@infograf768 Please can you test #22985 as a replacement for your PR and my other issue

avatar infograf768
infograf768 - comment - 10 Nov 2018

Closing as we have a better patch #22985 and we can discuss there.

avatar infograf768 infograf768 - change - 10 Nov 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-11-10 06:51:46
Closed_By infograf768
Labels Added: J4 Issue ?
avatar infograf768 infograf768 - close - 10 Nov 2018

Add a Comment

Login with GitHub to post a comment