User tests: Successful: Unsuccessful:
Install an older language pack, for example:
fr-FR_joomla_lang_full_3.9.0v2.zip
Display Control Panel
An extension update is proposed.
Note: process would be similar for Joomla Update
message
is not translated.
A supplementary useless error info
message is displayed.
Needs running npm ci
Status | New | ⇒ | Pending |
Category | ⇒ | JavaScript Repository Front End Plugins |
After patch I got: (no error part this time, ignoring the background issue)
I have tested this item
as per notes above
The fact that you get no background is weird.
I guess we can change here the Message
to a Warning
to get the right colour. Not sure. Would have to test.
Im just about to do the school run - so no time to dig deeper - logged issue so it doesnt get lost
let’s wait abit here asit lookks like joomla.render.messages is confusing.
Yup - see my other pr comment
I’ve had to do the school run and now sat outside in the rain for an hour at gymnastics with her so could not continue to dig deeper and resolve this right away like the other one
Looks like the messages renderer has multiple issues to resolve :-(
——
Sent from my iPhone - sorry - if needed I’ll send longer email from my desk later.
——
On 9 Nov 2018, at 17:27, infograf768 notifications@github.com wrote:
let’s wait abit here asit lookks like joomla.render.messages is confusing.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
@infograf768 Please can you test #22985 as a replacement for your PR and my other issue
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-11-10 06:51:46 |
Closed_By | ⇒ | infograf768 | |
Labels |
Added:
J4 Issue
?
|
Before applying patch I get no backgrounds: