? Pending

User tests: Successful: Unsuccessful:

avatar sven-ahrens
sven-ahrens
16 Oct 2018

Summary of Changes

Removed any jQuery code and rebuilt it with ECMAScript 6.

Testing Instructions

  1. Login into the backend of your joomla! site

  2. (Toggle the side navigation if hidden)

  3. Click on "Menus" and choose an administrator menu if available. If not, you'll need to create one

  4. After being redirected to the "Menus: Items" page: Click on "new" to create an new item

  5. Now you should be able to select the menu item type. Click on "select"

  6. Choose: "System Links". A dropdown will open. There, you have to choose: "Components Menu Container"

  7. At the middle of the page should be a list in form of a tree.

Expected result

The list has sevaral "root" elements, which is, a list-item, which contains a subtree.
Current "root elements" on this page are: "All", "Banners", "Contacts", "Messaging" and "News Feeds".
Clicking on one of them should instantly check and disable all elements, which are hold inside of this root.

For example: Clicking on "All" should check and disable every checkbox on the screen. Of course, if you click it again, every checkbox will be unchecked and enabled.

  • Check means, that the checkbox color and text will change to red
  • disable means, that the checkbox is still red, but lighter due to less opacity

If a checkbox is either checked nor disabled it's default color is green.

Clicking on a item, which is not a root, will be checked(color switches to red) but not disabled, because you wouldn't be able to click it again.

Now apply the patch from this PR , re-run npm and verify that the functionality described above still works as expected.

avatar sven-ahrens sven-ahrens - open - 16 Oct 2018
avatar sven-ahrens sven-ahrens - change - 16 Oct 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Oct 2018
Category JavaScript Repository
avatar sven-ahrens sven-ahrens - change - 16 Oct 2018
Labels Added: ?
avatar SniperSister
SniperSister - comment - 16 Oct 2018

I have tested this item successfully on 252e730

Works as described! Note for other testers: the expected behavior is broken in the current j4 branch, for reference look at the behavior in a 3.x installation


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22667.

avatar SniperSister SniperSister - test_item - 16 Oct 2018 - Tested successfully
avatar dgrammatiko
dgrammatiko - comment - 16 Oct 2018

Array.from needs to be polyfilled. Use [].slice.call() instead which works out of the box even in older browsers eg ie

avatar infograf768 infograf768 - change - 17 Oct 2018
Title
Refactored admin-item-edit_container.es6.js to no longer use jQuery anymore
[4.0] Refactored admin-item-edit_container.es6.js to no longer use jQuery anymore
avatar infograf768 infograf768 - edited - 17 Oct 2018
avatar joomla-cms-bot joomla-cms-bot - change - 17 Oct 2018
Category JavaScript Repository JavaScript Repository External Library Composer Change
avatar sven-ahrens sven-ahrens - change - 17 Oct 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 17 Oct 2018
Category JavaScript Repository External Library Composer Change JavaScript Repository
avatar laoneo laoneo - change - 17 Oct 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-10-17 15:16:27
Closed_By laoneo
Labels Removed: ?
avatar laoneo laoneo - close - 17 Oct 2018
avatar laoneo laoneo - merge - 17 Oct 2018
avatar laoneo
laoneo - comment - 17 Oct 2018

Very good work! Thanks.

Add a Comment

Login with GitHub to post a comment