[#22668] - Improve performance of #__session with a large session count - New Index
- Closed
- 22 Feb 2019
- Medium
- Build: staging
- # 22668
- Diff
- tonypartridge:staging-session-index
- Success Hound No violations found. Woof! Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #22632 .
Summary of Changes
Adds a new index 'client_guest' against client and guest columns
Testing Instructions
Have a large sessions table i.e. 14,000 rows. You can use a script I created to add these;
https://gist.github.com/tonypartridge/43c3d6f2f47d566fa8f7a28c9c4089a8
Expected result
as it is now but faster
Actual result
as it is now
Documentation Changes Required
The index will improve session query performance on MySQL databases. Omn average I am seeing a 30ms session query brought down to around 8ms saving 22ms.
Note, testing should be done on non-cached queries.
| Status | New | ⇒ | Pending |
| Category | ⇒ | SQL Administration com_admin Installation |
don't forget postgresql , mssql
| Labels |
Added:
?
|
||
don't forget postgresql , mssql
@alikon I don't have a postgresql or mssql, or azuresql instance to test against, it's not 100% needed for those databases. This is just a PR against the mysql one to further improve performance.
Feel free to submit a PR for those too as well.
The database schema should be consistent across platforms, including indexes. So if we're changing MySQL, the others should be changed at the same time.
@mbabker so you want me to do the schemes without being able to test?
On 17 Oct 2018, 16:53 +0100, Michael Babker notifications@github.com, wrote:
The database schema should be consistent across platforms, including indexes. So if we're changing MySQL, the others should be changed at the same time.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
brianteeman
- | Title |
|
||||||
@tonypartridge sorry, but unable to sumbit a pr to your branch
see #23650
| Closed_Date | 2019-02-22 19:10:33 | ⇒ | 2019-02-22 19:10:34 |
| Closed_By | Quy | ⇒ | joomla-cms-bot |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-02-22 19:10:33 |
| Closed_By | ⇒ | Quy |
Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/22668
Please test PR #23650
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22668.
see #22632
I cant close it due to the personal attacks and thread drift locking the issue