? Success

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
16 Oct 2013

Currently, the postinstall messages are inserted into the table with a postinstall_message_id.
This PR removes the postinstall_message_id from those INSERT queries and lets the database use the autoincrement value instead.

The postinstall_message_id isn't used as a foreign key in other tables, thus we don't have to specify it in the query.

Assuming that 3rd party extensions may use this messages as well, we will face problems if we want to insert a message in Joomla 3.2.x after a 3rd party already inserted some own messages. The id may already be taken then and our query will fail.

Tracker:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32330

avatar Bakual Bakual - open - 16 Oct 2013
avatar mbabker mbabker - close - 23 Oct 2013
avatar Bakual Bakual - head_ref_deleted - 24 Oct 2013
avatar garyamort garyamort - reference | - 2 Dec 13

Add a Comment

Login with GitHub to post a comment