Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#22593] - [4.0] Smart Search: Adding debug information

? ? Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
12 Oct 2018

Summary of Changes

When running the indexer of Smart Search in the backend, the output is very unsatisfying for debugging. When debugging is enabled, this PR adds a list of all contexts that are being indexed with the total number of items to index and the currently indexed items.

Testing Instructions

  1. Apply PR
  2. Run npm i
  3. Enable debugging in global configuration
  4. Run the indexer of Smart Search in the backend and see the
avatar Hackwar Hackwar - open - 12 Oct 2018
avatar Hackwar Hackwar - change - 12 Oct 2018
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Oct 2018
Category ⇒ Administration com_finder JavaScript Repository
avatar Hackwar Hackwar - change - 13 Oct 2018
Labels Added: ?
avatar laoneo
laoneo - comment - 18 Oct 2018

Can you make the dog here happy?

avatar Hackwar
Hackwar - comment - 18 Oct 2018

Unfortunately no. I don't know the best solution for these issues and if you could help me with this, I'd be very gratefull.

avatar wilsonge
wilsonge - comment - 29 Oct 2018

Woof is happy.

https://eslint.org/docs/rules/prefer-template (formatting strings
https://eslint.org/docs/rules/guard-for-in (you were missing the hasOwnProperty on one loop and on the other on a style eslint didn't like)

Finally we're using the airbnb style guide which chooses to disallow for in loops because of the whole prototype thing https://github.com/airbnb/javascript#iterators--nope

To fix that i used Object.entries which isn't the most efficient ever (Object.keys is probably better looking for 10 seconds at https://hackernoon.com/5-techniques-to-iterate-over-javascript-object-entries-and-their-performance-6602dcb708a8 ). But I wasn't sure exactly what the data structure was as was just doing this from github editor (if we had key => value or just a list)

avatar TobsBobs
TobsBobs - comment - 1 Dec 2018

I have tested this item ? unsuccessfully on 9d63258

I apply this patch and run npm install. Without this patch the indexer runs correctly. With patch applied the indexer don´t run.

With patch:
1

Without patch:
2

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22593.
avatar TobsBobs TobsBobs - test_item - 1 Dec 2018 - Tested unsuccessfully
avatar Hackwar
Hackwar - comment - 1 Dec 2018

I've gone through this again and hopefully fixed it. Can you check again?

avatar TobsBobs
TobsBobs - comment - 1 Dec 2018

I have tested this item ✅ successfully on b042459

unbenannt

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22593.

avatar TobsBobs TobsBobs - test_item - 1 Dec 2018 - Tested successfully
avatar Quy
Quy - comment - 1 Dec 2018

I have tested this item ✅ successfully on b042459

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22593.

avatar Quy Quy - change - 1 Dec 2018
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 1 Dec 2018

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22593.

avatar Quy Quy - test_item - 1 Dec 2018 - Tested successfully
avatar laoneo laoneo - change - 3 Dec 2018
Labels Added: ?
avatar wilsonge wilsonge - close - 11 Dec 2018
avatar wilsonge wilsonge - merge - 11 Dec 2018
avatar wilsonge wilsonge - change - 11 Dec 2018
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-12-11 13:50:44
Closed_By ⇒ wilsonge

Add a Comment

Login with GitHub to post a comment