[#22594] - [4.0] Workflow stage delete publish
- Closed
- 27 May 2020
- Medium
- Build: 4.0-dev
- # 22594
- Diff
- chmst:workflow-stage-delete-publish
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr the build was successful Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #21846
Summary of Changes
Remove the method delete() from stageTable to stageModel.
Doing this some fixes have been added, comments and code have been improved
Testing Instructions
Make a workflow with several stages and transitions.
Now try to change the status of one or more stages, thrash them, unpublish them.
If you try to trash a default state, you must get an alert.
Use the filter "trashed" and delete trashed stages.
Make sure that the transitions to and from the deletes stages are deleted too.
Expected result
All changes are correct, all alerts are correct
Actual result
The alert for trashing the default stage is wrong (see #21846)
Trashing several stages results in wrong conditions for stages.
Documentation Changes Required
no
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_workflow |
| Title |
|
||||||
| Title |
|
||||||
| Labels |
Added:
?
|
||
Where do we stay here? Is the pr ready?
For me, it is ready, as it does not change something in the behaviour but fixes a but in a method call.
| Labels |
Added:
Conflicting Files
|
||
| Labels |
Removed:
Conflicting Files
|
||
| Category | Administration com_workflow | ⇒ | Administration com_workflow Language & Strings |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22594.
franz-wohlkoenig
- | Category | Administration com_workflow Language & Strings | ⇒ | Administration com_workflow |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22594.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22594.
Not longer valid, closed
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-05-27 08:57:31 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
Conflicting Files
|
||
| Category | Administration com_workflow | ⇒ | Administration com_workflow Language & Strings |
@chmst Please fix cs errors reported here.