? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
6 Sep 2018

Pull Request for Issue #22025

Summary of Changes

The calendar js is using the clear variable and not the save variable to clear the field.
Therefore the button Clear is NOT translated when using another language.

The js code is clear ( ? )
this._nav_clear = hh(JoomlaCalLocale.clear, '', 100, 'button', '', 'js-btn btn btn-clear', {"type": "button", "data-action": "clear"});

and not save...

Testing Instructions

Click on a calendar icon in backend publishing article tab and look at the buttons at the bottom when using another language than English (therefore not en-GB, en-US, en-Ca, etc if any)

Test in French

Before patch

screen shot 2018-09-06 at 18 05 29

After patch

screen shot 2018-09-06 at 18 03 19

@boomsya

avatar infograf768 infograf768 - open - 6 Sep 2018
avatar infograf768 infograf768 - change - 6 Sep 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Sep 2018
Category JavaScript Language & Strings
avatar brianteeman
brianteeman - comment - 6 Sep 2018

I have tested this item successfully on 9cb6150


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22026.

avatar brianteeman brianteeman - test_item - 6 Sep 2018 - Tested successfully
avatar richard67
richard67 - comment - 6 Sep 2018

I have tested this item successfully on 9cb6150


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22026.

avatar richard67 richard67 - test_item - 6 Sep 2018 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 6 Sep 2018
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 6 Sep 2018

Ready to Commit after two successful tests.

avatar zero-24
zero-24 - comment - 7 Sep 2018

Thanks @infograf768 and @boomsya for reporting and fixing as well as the testers ?

avatar zero-24 zero-24 - change - 7 Sep 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-09-07 07:20:04
Closed_By zero-24
Labels Added: ?
avatar zero-24 zero-24 - close - 7 Sep 2018
avatar zero-24 zero-24 - merge - 7 Sep 2018

Add a Comment

Login with GitHub to post a comment