?
avatar boomsya
boomsya
6 Sep 2018

joomla 3.8.12
today i was modify one of component which contain Ukrainian interface
and i have found what dropdown calendar does not translate button "Clear" on calendar

so i was open media/system/js/fields/calendar-locales/uk.js (and also files)

window.JoomlaCalLocale = {
	today : "Сьогодні",
	weekend : [0, 6],
	wk : "тждн.",
	time : "Час:",
	days : ["Неділя", "Понеділок", "Вівторок", "Середа", "Четвер", "П'ятниця", "Субота"],
	shortDays : ["Нд.", "Пн.", "Вт.", "Ср.", "Чт.", "Пт.", "Сб."],
	months : ["Січень", "Лютий", "Березень", "Квітень", "Травень", "Червень", "Липень", "Серпень", "Вересень", "Жовтень", "Листопад", "Грудень"],
	shortMonths : ["Січ.", "Лют.", "Бер.", "Квіт.", "Трав.", "Черв.", "Лип.", "Серп.", "Вер.", "Жовт.", "Лист.", "Груд."],
	AM : "AM",
	PM :  "PM",
	am : "am",
	pm : "pm",
	dateType : "gregorian",
	minYear : 1900,
	maxYear : 2100,
	exit: "Закрити",
	save: "Очистити"
};

param "save" translated as "Clear" in english translation. This is wrong translation. It must be "Зберегти",
in Russian translation it must be "Сохранить" too.

and this is translation list does not contain param 'clear'.
In Ukrainian translation it must be clear: "Очистити"
and in russian it must be clear: "Очистить"

avatar boomsya boomsya - open - 6 Sep 2018
avatar joomla-cms-bot joomla-cms-bot - change - 6 Sep 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 6 Sep 2018
avatar zero-24
zero-24 - comment - 6 Sep 2018

@infograf768 can you forward this to the respective TT's?

avatar boomsya
boomsya - comment - 6 Sep 2018

uk.js right version:


window.JoomlaCalLocale = {
	today : "Сьогодні",
	weekend : [0, 6],
	wk : "тждн.",
	time : "Час:",
	days : ["Неділя", "Понеділок", "Вівторок", "Середа", "Четвер", "П'ятниця", "Субота"],
	shortDays : ["Нд.", "Пн.", "Вт.", "Ср.", "Чт.", "Пт.", "Сб."],
	months : ["Січень", "Лютий", "Березень", "Квітень", "Травень", "Червень", "Липень", "Серпень", "Вересень", "Жовтень", "Листопад", "Грудень"],
	shortMonths : ["Січ.", "Лют.", "Бер.", "Квіт.", "Трав.", "Черв.", "Лип.", "Серп.", "Вер.", "Жовт.", "Лист.", "Груд."],
	AM : "AM",
	PM :  "PM",
	am : "am",
	pm : "pm",
	dateType : "gregorian",
	minYear : 1900,
	maxYear : 2100,
	exit: "Закрити",
	save: "Зберегти",
	clear: "Очистити"
};

ru.js right version:

window.JoomlaCalLocale = {
	today : "Сьогодні",
	weekend : [0, 6],
	wk : "тждн.",
	time : "Час:",
	days : ["Неділя", "Понеділок", "Вівторок", "Середа", "Четвер", "П'ятниця", "Субота"],
	shortDays : ["Нд.", "Пн.", "Вт.", "Ср.", "Чт.", "Пт.", "Сб."],
	months : ["Січень", "Лютий", "Березень", "Квітень", "Травень", "Червень", "Липень", "Серпень", "Вересень", "Жовтень", "Листопад", "Грудень"],
	shortMonths : ["Січ.", "Лют.", "Бер.", "Квіт.", "Трав.", "Черв.", "Лип.", "Серп.", "Вер.", "Жовт.", "Лист.", "Груд."],
	AM : "AM",
	PM :  "PM",
	am : "am",
	pm : "pm",
	dateType : "gregorian",
	minYear : 1900,
	maxYear : 2100,
	exit: "Закрити",
	save: "Сохранить",
	clear: "Очистить"
};

english version wrong too. I think it is global mistake.

avatar boomsya boomsya - change - 6 Sep 2018
The description was changed
avatar boomsya boomsya - edited - 6 Sep 2018
avatar infograf768
infograf768 - comment - 6 Sep 2018

Mistake also in en.js?

Sorry to say, but all calendar language js files are made on the model of en.js where we have

	exit: "Close",
	save: "Clear"

The param IS "save" but the value IS "Clear" and that is what it does, i.e. clearing the field.
Saving is done by hitting the "Enter" key or next to the dropdown.

avatar infograf768
infograf768 - comment - 6 Sep 2018

clear

avatar boomsya
boomsya - comment - 6 Sep 2018

button "Clear" works fine but it is not translating in other languages.
because option "clear" is missing and his value now into option "save" but "save" not using in calendar.
and option "save" translated wrong

avatar infograf768
infograf768 - comment - 6 Sep 2018

What the heck. You are partly right.
We must not change the value but the param indeed.
In English it is always fine, but not for other languages.
We need to change all the language locales to (for French)

clear: "Effacer"

instead of

save: "Effacer"

We do not need the option save:"whatever" at all...

will do patch now for all locales.

Thanks you for pointing to this issue.

avatar franz-wohlkoenig franz-wohlkoenig - change - 6 Sep 2018
Status New Discussion
avatar franz-wohlkoenig franz-wohlkoenig - change - 6 Sep 2018
Category JavaScript Language & Strings
avatar infograf768
infograf768 - comment - 6 Sep 2018

Please test #22026

avatar infograf768
infograf768 - comment - 6 Sep 2018

Closing as we have patch

avatar infograf768 infograf768 - change - 6 Sep 2018
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2018-09-06 16:08:52
Closed_By infograf768
avatar infograf768 infograf768 - close - 6 Sep 2018

Add a Comment

Login with GitHub to post a comment