? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
31 Aug 2018

com_fields
com_csp
com_installer

Continuation of #21933

avatar brianteeman brianteeman - open - 31 Aug 2018
avatar brianteeman brianteeman - change - 31 Aug 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Aug 2018
Category Administration com_contact com_csp com_fields com_installer
9bb6832 31 Aug 2018 avatar brianteeman cs
avatar brianteeman brianteeman - change - 31 Aug 2018
Labels Added: ?
f185c73 1 Sep 2018 avatar brianteeman wrap
avatar ciar4n
ciar4n - comment - 1 Sep 2018

nowrap is been applied here to all table headers... https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/templates/atum/scss/vendor/bootstrap/_table.scss#L7

Should either remove this CSS and use the bootstrap nowrap utility class everywhere where needed. Or keep it and remove all the nowrap classes from table headers.

avatar brianteeman
brianteeman - comment - 1 Sep 2018

Ok cool so I can remove all the nowrap then. Makes it easier for all.

avatar brianteeman
brianteeman - comment - 1 Sep 2018

I will deal with nowrap in its own pr

avatar brianteeman
brianteeman - comment - 4 Sep 2018

@zwiastunsw Can you test this one as well please Stefan so I can move on to the next stage

avatar renekreijveld
renekreijveld - comment - 8 Sep 2018

I have tested this item successfully on f185c73

Before patch applied:
Inspected all column headings for presence of class="text-center".
Applied patch
Verified all classes were modified.
Still one problem: administrator/components/com_csp/tmpl/reports/default.php, line 117
Originally contained twice the class "text-center" and only one is removed.
I could NOT test the extensions update view as Joomla didn't discover extension updates.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21938.

avatar renekreijveld renekreijveld - test_item - 8 Sep 2018 - Tested successfully
avatar wilsonge wilsonge - change - 8 Sep 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-09-08 12:33:50
Closed_By wilsonge
avatar wilsonge wilsonge - close - 8 Sep 2018
avatar wilsonge wilsonge - merge - 8 Sep 2018
avatar brianteeman
brianteeman - comment - 8 Sep 2018

Thanks

Add a Comment

Login with GitHub to post a comment