? ? ? Pending

User tests: Successful: Unsuccessful:

avatar bembelimen
bembelimen
31 Aug 2018

Summary of Changes

After #21506 now translate the workflows themselves via language files

Testing Instructions

Check the "Joomla! Default"-Workflow, rename it to "COM_WORKFLOW_DEFAULT_WORKFLOW".

Expected result

The workflow should be translated everywhere

Actual result

Workflow not translated

@infograf768

avatar bembelimen bembelimen - open - 31 Aug 2018
avatar bembelimen bembelimen - change - 31 Aug 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Aug 2018
Category SQL Administration com_admin Postgresql com_content com_workflow Language & Strings Installation Libraries
avatar bembelimen bembelimen - change - 31 Aug 2018
Title
Translate workflow via language file
[4.0] Translate workflows via language file
avatar bembelimen bembelimen - edited - 31 Aug 2018
avatar bembelimen bembelimen - change - 31 Aug 2018
Labels Added: ? ?
avatar infograf768
infograf768 - comment - 1 Sep 2018

Code works fine.
Next step will be adding everywhere we use Constants the translation below the title as we do for custom admin menus.
See #19916

avatar infograf768
infograf768 - comment - 8 Sep 2018

Conflicts have to be resolved here.

avatar brianteeman
brianteeman - comment - 8 Sep 2018

Conflicts all resolved

avatar f-hamel
f-hamel - comment - 8 Sep 2018

I have tested this item ? unsuccessfully on 7c2fdfc

Hi can't apply patch because there seem to conflicts in the language file with #21579

The patch could not be applied because it conflicts with a previously applied patch: administrator/language/en-GB/en-GB.com_workflow.ini

```<hr /><sub>This comment was created with the <a href="https://github.com/joomla/jissues">J!Tracker Application</a> at <a href="https://issues.joomla.org/tracker/joomla-cms/21939">issues.joomla.org/tracker/joomla-cms/21939</a>.</sub>
avatar f-hamel
f-hamel - comment - 8 Sep 2018

I have tested this item ? unsuccessfully on 7c2fdfc

Hi can't apply patch because there seem to conflicts in the language file with #21579

The patch could not be applied because it conflicts with a previously applied patch: administrator/language/en-GB/en-GB.com_workflow.ini

```<hr /><sub>This comment was created with the <a href="https://github.com/joomla/jissues">J!Tracker Application</a> at <a href="https://issues.joomla.org/tracker/joomla-cms/21939">issues.joomla.org/tracker/joomla-cms/21939</a>.</sub>
avatar f-hamel f-hamel - test_item - 8 Sep 2018 - Tested unsuccessfully
avatar Didldu-Florian
Didldu-Florian - comment - 8 Sep 2018

I have tested this item successfully on 7c2fdfc

Can't reproduce any conflicts in the language file with #21579 by applying the patch to the current nightly build!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21939.

avatar Didldu-Florian Didldu-Florian - test_item - 8 Sep 2018 - Tested successfully
avatar gorgonz
gorgonz - comment - 8 Sep 2018

I have tested this item successfully on 7c2fdfc

works as described


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21939.

avatar gorgonz gorgonz - test_item - 8 Sep 2018 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 8 Sep 2018
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 8 Sep 2018

Ready to Commit after two successful tests.

avatar spannama
spannama - comment - 8 Sep 2018

I have tested this item ? unsuccessfully on 7c2fdfc

Before Patch the renaming works successfully.
After Patch it doesn't work anymore.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21939.

avatar spannama
spannama - comment - 8 Sep 2018

I have tested this item ? unsuccessfully on 7c2fdfc

Before Patch the renaming works successfully.
After Patch it doesn't work anymore.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21939.

avatar spannama spannama - test_item - 8 Sep 2018 - Tested unsuccessfully
avatar bembelimen bembelimen - change - 8 Sep 2018
Labels Added: ?
avatar wilsonge wilsonge - change - 10 Sep 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-09-10 00:16:28
Closed_By wilsonge
avatar wilsonge wilsonge - close - 10 Sep 2018
avatar wilsonge wilsonge - merge - 10 Sep 2018

Add a Comment

Login with GitHub to post a comment