[#21937] - [3.9-alpha] [mod_articles_category] Make sure the tag does not conflict with the title of the article
- Fixed in Code Base
- 8 Sep 2018
- Medium
- Build: 3.9-dev
- # 21937
- Diff
- zero-24:modarticescategoryuntagged
User tests: Successful: Unsuccessful:
Pull Request for Issue #21083
Summary of Changes
I have moved the translation part to the view so the code does not work different on different languages. As currently the array key is the translated word already and in that case have different results depending on the used language this patch makes sure the result is always the same on all languages by translating the key later.
Testing Instructions
- install 3.9-alpha (with sample testing data)
- create and mod_articles_category with the new option (Group by tags) added here #21083
- Check that is displays good in the frontend
- Create an article with the Tag "Untagged"
- Notice that the article is listed in the Untagged list in the frontend.
- apply this patch
- Joomla differentiate now between actually tagged and not tagged articles.
Expected result
Joomla differentiate now between actually tagged and not tagged articles.
Actual result
Joomla does not differentiate between actually tagged and not tagged articles.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
What do you mean? Without this the ordering is always different per language and can result into false positives when the article title is the same like the translation. Not to forget some maybe illegal chars for an array key in the translation.
Alphabetical ordering. Untagged will always be where M should be because of language key. I guess, because it's not a real tag, we could just append it to the list. See zero-24#39 for possible solution.
| Labels |
Added:
?
|
||
I have merged your PR. Thanks!
Not clear what should happen here. Without patch: list is rendered, with the new tagged article at the bottom of the list.
With patch: list is rendered, with the new tagged article at the top of the list.
Is this the expected outcome?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21937.
I have tested this item
With patch the article is listed under the label "Untagged"
After patch the article is listed under the label "Untagged", which is now a real tag heading. Other articles are grouped with "Untagged" at end of the list.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21937.
I have tested this item
With patch the article is listed under the label "Untagged"
After patch the article is listed under the label "Untagged", which is now a real tag heading. Other articles are grouped with "Untagged" at end of the list.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21937.
I have tested this item
Ah. Tag needed a capital to render expected outcome.
Without patch: tagged article appears in Untagged items
With patch: tagged article appears in items with tag Untagged.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21937.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
I have tested this item
Steps reproduced. Works as expected
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21937.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-09-08 15:35:16 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
Thanks
This breaks ordering.