Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#21836] - [4.0] Workflow Enable/Disable

? ? ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
24 Aug 2018

Instead of published/unpublished/trashed this pr changes the status for workflows/stages/transitions to enabled/disabled/trashed

This PR required fixing an obvious bug in the js select-colouur
Note that you will need to do a full npm install to test this

image

Pull Request for Issue #21757

avatar brianteeman brianteeman - open - 24 Aug 2018
avatar brianteeman brianteeman - change - 24 Aug 2018
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Aug 2018
Category ⇒ Administration com_media com_workflow Language & Strings JavaScript Repository
avatar brianteeman
brianteeman - comment - 24 Aug 2018

@dgrammatiko can you double check the is changes please

avatar infograf768
infograf768 - comment - 24 Aug 2018

Also: there are changes to 2 package-lock.json? They do not look like related to this PR.

avatar wojsmol
wojsmol - comment - 24 Aug 2018

@infograf768 package-lock.json is wrongly regenerated - this depends on npm and node version - see #21772

avatar brianteeman brianteeman - change - 24 Aug 2018
Labels Added: ? ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 24 Aug 2018
Category Administration com_media com_workflow Language & Strings JavaScript Repository ⇒ Administration com_media
avatar brianteeman brianteeman - change - 24 Aug 2018
Labels Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 24 Aug 2018
Category Administration com_media ⇒ Administration com_media com_workflow Language & Strings JavaScript Repository
113da70 24 Aug 2018 avatar brianteeman locks
avatar brianteeman brianteeman - change - 24 Aug 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 24 Aug 2018
Category Administration com_media com_workflow Language & Strings JavaScript Repository ⇒ Administration com_workflow Language & Strings JavaScript Repository
avatar brianteeman
brianteeman - comment - 24 Aug 2018

removed the lock files

avatar bembelimen
bembelimen - comment - 24 Aug 2018

I have tested this item ✅ successfully on 113da70

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21836.

avatar bembelimen bembelimen - test_item - 24 Aug 2018 - Tested successfully
avatar chmst
chmst - comment - 25 Aug 2018

I have tested this item successfully, the options for status are changed as described.

Toolbar-Buttons, messages and the Table select are still the publish/unpublish.

avatar chmst
chmst - comment - 25 Aug 2018

I have tested this item ✅ successfully on 113da70

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21836.

avatar chmst chmst - test_item - 25 Aug 2018 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 26 Aug 2018
Status Pending ⇒ Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 26 Aug 2018

Ready to Commit after two successful tests.

avatar wilsonge wilsonge - change - 7 Sep 2018
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-09-07 18:50:20
Closed_By ⇒ wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 7 Sep 2018
avatar wilsonge wilsonge - merge - 7 Sep 2018
avatar wilsonge
wilsonge - comment - 7 Sep 2018

Thanks!

avatar brianteeman
brianteeman - comment - 7 Sep 2018

Thanks

Add a Comment

Login with GitHub to post a comment