Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#21837] - [3.9] Update the type of $displayData for LayoutHelper::render() (and actually fix my original complaint)

? Pending

User tests: Successful: Unsuccessful:

avatar clayfreeman
clayfreeman
24 Aug 2018

I had a previous PR (#21674) where I updated the inline documentation to fix a parameter type mismatch, but I just realized that I updated the wrong method. The old PR isn't wrong per-se, however, I need to actually fix my original problem.

Summary

This PR updates the type of the LayoutHelper::render() method's $displayData parameter to be mixed. This parameter commonly accepts arrays for various layout objects (i.e. search tools).

avatar clayfreeman clayfreeman - open - 24 Aug 2018
avatar clayfreeman clayfreeman - change - 24 Aug 2018
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Aug 2018
Category ⇒ Libraries
avatar clayfreeman clayfreeman - change - 24 Aug 2018
Title
…
[3.9] Actually fix my original complaint
[3.9] Update the type of `$displayData` for `LayoutHelper::render()` (and actually fix my original complaint)
avatar clayfreeman clayfreeman - edited - 24 Aug 2018
avatar clayfreeman clayfreeman - change - 24 Aug 2018
Title
…
[3.9] Update the type of `$displayData` for `LayoutHelper::render()` (and actually fix my original complaint)
[3.9] Update the type of $displayData for LayoutHelper::render() (and actually fix my original complaint)
avatar clayfreeman clayfreeman - edited - 24 Aug 2018
avatar clayfreeman clayfreeman - change - 28 Aug 2018
Labels Added: ?
avatar clayfreeman
clayfreeman - comment - 4 Sep 2018

@brianteeman @mbabker cc

avatar mbabker mbabker - change - 9 Sep 2018
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-09-09 17:13:43
Closed_By ⇒ mbabker
avatar mbabker mbabker - close - 9 Sep 2018
avatar mbabker mbabker - merge - 9 Sep 2018

Add a Comment

Login with GitHub to post a comment