? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
23 Aug 2018

Summary of Changes

Created cassiopea offline.scss file
Corrected the css there to display title and default text, as well as adapting one to rtl
Corrected offline.php to load template-rtl.css when necessary
Modified .gitignore to now ignore all css files for cassiopea

Testing Instructions

NOT for Patchtesters!

Install Joomla. Run npm install.
Now cassiopea css folder will contain

offline.css
offline.min.css
template-rtl.css
template-rtl.min.css
template.css
template.min.css

Set the site offline. Load frontend.
Now we will get (Multilingual site with template styles for each Content Language)
LTR:

screen shot 2018-08-22 at 18 15 39

RTL
screen shot 2018-08-22 at 18 15 22

@wilsonge @laoneo @Bakual

avatar infograf768 infograf768 - open - 23 Aug 2018
avatar infograf768 infograf768 - change - 23 Aug 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Aug 2018
Category Repository JavaScript Front End Templates (site)
avatar infograf768
infograf768 - comment - 23 Aug 2018

looks like I have to do a lot hound corrections.... grr I hate hound...

avatar infograf768 infograf768 - change - 23 Aug 2018
Labels Added: ?
avatar wilsonge wilsonge - change - 23 Aug 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-08-23 09:11:06
Closed_By wilsonge
avatar wilsonge wilsonge - close - 23 Aug 2018
avatar wilsonge wilsonge - merge - 23 Aug 2018
avatar wilsonge
wilsonge - comment - 23 Aug 2018

LGTM! Thanks JM!

avatar infograf768
infograf768 - comment - 23 Aug 2018

just saw a small mistake for RTl
Will correct with new PR asap

Add a Comment

Login with GitHub to post a comment