? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
23 Aug 2018

Pull Request for pr #21790.

Summary of Changes

As #21790 revealed, the manifest files in core are out of sync. Before I'm going to fix all of them I would like to get some feedback what all needs to be adapted.

Beside the folders I would also change the compatibility version and the version of the extension itself. Anything else?

avatar laoneo laoneo - open - 23 Aug 2018
avatar laoneo laoneo - change - 23 Aug 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Aug 2018
Category Administration com_content
avatar brianteeman
brianteeman - comment - 23 Aug 2018

other than the missing file it looks ok to me

would be good to get another check though

avatar laoneo laoneo - change - 23 Aug 2018
Labels Added: ?
16262bc 23 Aug 2018 avatar laoneo nl
avatar laoneo
laoneo - comment - 24 Aug 2018

Added also media folder.

avatar brianteeman
brianteeman - comment - 28 Aug 2018

I am wondering if we even need these manifest files for core components and with the move of media files if they should be in the manifest either

avatar mbabker
mbabker - comment - 28 Aug 2018

Yes the extension manifests should be in place. Technically, we don't need them, but the core package shouldn't be taking liberties as it relates to extension structure that a distributed extension can't.

avatar brianteeman
brianteeman - comment - 28 Aug 2018

And the media folder? The same?

@laoneo did you have to create this manually - if so I am happy to takeover so you can concentrate on developer stuff

avatar laoneo
laoneo - comment - 29 Aug 2018

For me it reflects the installed state of an extension which includes the media folder and com_content has a media folder. From my understanding an extension dev should be able to take it as example and the manifest with the media folder is part of it.

I can remove it if you really want but I think it is not a bad idea to leave it in.

@brianteeman yes I'm doing them by hand. If you want you can take over the task when we get this one merged. But I would wait about the agreement of the media folder.

avatar brianteeman
brianteeman - comment - 29 Aug 2018

When you decide on media let me know and i can get this done

avatar wilsonge wilsonge - change - 10 Sep 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-09-10 10:39:27
Closed_By wilsonge
avatar wilsonge wilsonge - close - 10 Sep 2018
avatar wilsonge wilsonge - merge - 10 Sep 2018
avatar wilsonge
wilsonge - comment - 10 Sep 2018

Not convinced about the media tag - but not sceptical enough to block progress here

Add a Comment

Login with GitHub to post a comment