? ? Pending

User tests: Successful: Unsuccessful:

avatar ciar4n
ciar4n
17 Aug 2018

Pull Request for Issue # .

Summary of Changes

In the Help and System pages, this PR makes the entire list item clickable rather than just the text.

Testing Instructions

Apply PR navigate to Help or System. Full items should be clickable rather than just the text.

avatar ciar4n ciar4n - open - 17 Aug 2018
avatar ciar4n ciar4n - change - 17 Aug 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Aug 2018
Category Administration Templates (admin)
avatar brianteeman brianteeman - test_item - 17 Aug 2018 - Tested successfully
avatar brianteeman
brianteeman - comment - 17 Aug 2018

I have tested this item successfully on 74afed2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21659.

avatar brianteeman
brianteeman - comment - 17 Aug 2018

I have tested this item successfully on 74afed2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21659.

avatar ghazal ghazal - test_item - 17 Aug 2018 - Tested successfully
avatar ghazal
ghazal - comment - 17 Aug 2018

I have tested this item successfully on 74afed2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21659.

avatar ghazal
ghazal - comment - 17 Aug 2018

I have tested this item successfully on 74afed2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21659.

avatar franz-wohlkoenig franz-wohlkoenig - change - 17 Aug 2018
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 17 Aug 2018

Ready to Commit after two successful tests.

avatar C-Lodder
C-Lodder - comment - 17 Aug 2018

<a class="list-group-item list-group-item-action">?

avatar ciar4n
ciar4n - comment - 17 Aug 2018

a class="list-group-item list-group-item-action"

And remove the li?

avatar C-Lodder
C-Lodder - comment - 17 Aug 2018

And the <ul> too. Just use a div

avatar ciar4n ciar4n - change - 17 Aug 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 17 Aug 2018
Category Administration Templates (admin) Administration com_cpanel Templates (admin)
avatar ciar4n
ciar4n - comment - 17 Aug 2018

Amended inline with Charlie's suggestion

avatar brianteeman
brianteeman - comment - 17 Aug 2018

Sorry but the changes requested by @C-Lodder are wrong. These are lists and should be marked up as lists. Particularly important for a11y.

avatar ciar4n ciar4n - change - 17 Aug 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 17 Aug 2018
Category Administration Templates (admin) com_cpanel Administration Templates (admin)
avatar ciar4n
ciar4n - comment - 17 Aug 2018

Previous commit reverted. Now back to lists.

avatar joomla-cms-bot joomla-cms-bot - change - 17 Aug 2018
Category Administration Templates (admin) Administration Templates (admin) Installation Front End Templates (site)
avatar wilsonge wilsonge - change - 17 Aug 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-08-17 19:44:01
Closed_By wilsonge
avatar wilsonge wilsonge - close - 17 Aug 2018
avatar wilsonge wilsonge - merge - 17 Aug 2018

Add a Comment

Login with GitHub to post a comment