Feeling Lucky
?
[#21658] - [4.0] Fix switcher colors
- Fixed in Code Base
- 17 Aug 2018
- Medium
- Build: 4.0-dev
- # 21658
- Diff
- ciar4n:fix-switcher-colors
User tests: Successful: Unsuccessful:
Pull Request for Issue #21639 .
Summary of Changes
#21615 removed some required functions and variables which killed the color variations in the switcher. This PR fixes that.
Testing Instructions
Apply PR and run node build.js --compile-ce
Check switcher colors (article edit)
Before
See #21639
After
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository |
infograf768
- comment
- 17 Aug 2018
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21658.
franz-wohlkoenig
- comment
- 17 Aug 2018
@infograf768 thanks for "NOT for PatchTester users. Requires npm install (or node)".
brianteeman
- comment
- 17 Aug 2018
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21658.
| Status | Pending | ⇒ | Ready to Commit |
franz-wohlkoenig
- comment
- 17 Aug 2018
Ready to Commit after two successful tests.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-08-17 14:25:37 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 17 Aug 2018
Thanks!
ciar4n
- comment
- 17 Aug 2018
Thanks for the tests!
NOT for PatchTester users. Requires npm install (or node)