[#21660] - [4.0] Match styling for cpanel tables
- Fixed in Code Base
- 17 Aug 2018
- Medium
- Build: 4.0-dev
- # 21660
- Diff
- ciar4n:cpanel-table-style
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Gives tables matching styling to other modules in the cpanel.
Testing Instructions
Apply PR. Open cpanel
Before
After
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration Templates (admin) |
| Labels |
Added:
?
|
||
I find the complete lack of any "lines" make these tables very hard to read
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21660.
The template design as proposed joomla/40-backend-template#427
Has clearly defined lines to demarcate the rows
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
Please remove RTC - this does not match the design
| Status | Ready to Commit | ⇒ | Pending |
Status back on pending as stated above.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21660.
Status back on pending as stated above.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21660.
with #21665 this can be made rtc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21660.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21660.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21660.
Using PR #21660 and #21665 got Screenshot below which didn't look like joomla/40-backend-template#427 (Table Header)
joomla/40-backend-template#427 is for the article list, where this pr is for the cpanel.
The 'design' doesn't have a table header on these cpanel cards. If we insist on been strict to the design then that means removing the table header.
| Status | Pending | ⇒ | Ready to Commit |
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-08-17 13:28:08 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks guys!
I have tested this item✅ successfully on cd67a09
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21660.