[#21609] - [4.0] remove redundant code, tabs.js/scss
- Fixed in Code Base
- 14 Aug 2018
- Medium
- Build: 4.0-dev
- # 21609
- Diff
- dgrammatiko:es6/4.0-dev/remove-tabs
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
The actual code is fetched from joomla-projects/joomla-custom-elements, this existed in the repo as a help for @ciar4n and Charlie to do styling itterations
Testing Instructions
Tabs still work in article edit form, (they do!)
Expected result
Actual result
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository |
@franz-wohlkoenig nope
@wilsonge you don't even need a test here, take a look at: https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/cms/html/uitab.php#L42
after deleting these files and then running npm install I still have the typo
@brianteeman the code is fetched per release. the code George just merged in the other repo is not yet in the release we're fetching. Anyways I'm gonna make a change and always fetch the latest code ignoring the releases part as it complicates a lot the whole procedure...
@wilsonge @brianteeman done: #21610
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-08-14 13:36:22 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
1 tester here please just to confirm tabs are still as is in com_content