Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#21608] - [4.0] [a11y] cyan

? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
14 Aug 2018

the cyan color used for example on the help buttons on the toolbar fails the a11y color contrast checks

this small adjustment fixes that

Note that there are a lot of other small colour changes here that have been done automatically as a result of calculations based on the $cyan variable

before

chrome_2018-08-14_10-49-09

after

chrome_2018-08-14_10-48-55

(can be tested with patchtester)

avatar brianteeman brianteeman - open - 14 Aug 2018
avatar brianteeman brianteeman - change - 14 Aug 2018
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Aug 2018
Category ⇒ Administration Templates (admin) Installation Front End Templates (site)
avatar brianteeman brianteeman - change - 14 Aug 2018
The description was changed
avatar brianteeman brianteeman - edited - 14 Aug 2018
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 14 Aug 2018

I have tested this item ✅ successfully on d998f90

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21608.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 14 Aug 2018 - Tested successfully
avatar brianteeman brianteeman - change - 21 Aug 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 24 Aug 2018
Category Administration Templates (admin) Installation Front End Templates (site) ⇒ Administration Templates (admin) Front End Templates (site)
avatar brianteeman
brianteeman - comment - 24 Aug 2018

Conflicts resolved

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 30 Aug 2018

I have tested this item ? unsuccessfully on 2e88dd1

Background-Color stay after PR applied on #17a2b8.

System information

  • Nightly Build 4.0.0-alpha5-dev
  • Multilingual Sample Data (French, German DE, Persian)
  • Template: Cassiopeia
  • macOS Sierra, 10.13.6
  • Firefox 61 (64-bit)

CloudAccess.net

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 30 Aug 2018 - Tested unsuccessfully
avatar wojsmol
wojsmol - comment - 30 Aug 2018

@franz-wohlkoenig This PR requires npm - so no for patch tester users.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 30 Aug 2018

(can be tested with patchtester)

avatar wojsmol
wojsmol - comment - 30 Aug 2018

@franz-wohlkoenig This is not true any more after #21504 merge.
@brianteeman Please update testing instructions.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 30 Aug 2018

This is not true any more after #21504 merge.

Got it, thanks for Information @wojsmol.

avatar brianteeman brianteeman - change - 30 Aug 2018
The description was changed
avatar brianteeman brianteeman - edited - 30 Aug 2018
avatar zwiastunsw
zwiastunsw - comment - 2 Sep 2018

I have tested this item ✅ successfully on 2e88dd1

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21608.

avatar zwiastunsw zwiastunsw - test_item - 2 Sep 2018 - Tested successfully
avatar wojsmol
wojsmol - comment - 2 Sep 2018

I have tested this item ✅ successfully on 2e88dd1

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21608.

avatar wojsmol wojsmol - test_item - 2 Sep 2018 - Tested successfully
avatar Quy Quy - change - 3 Sep 2018
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 3 Sep 2018

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21608.

avatar laoneo laoneo - change - 3 Sep 2018
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-09-03 05:04:08
Closed_By ⇒ laoneo
Labels Added: ?
avatar laoneo laoneo - close - 3 Sep 2018
avatar laoneo laoneo - merge - 3 Sep 2018
avatar laoneo
laoneo - comment - 3 Sep 2018

Thanks

avatar brianteeman
brianteeman - comment - 3 Sep 2018

Thanks

Add a Comment

Login with GitHub to post a comment