[#21321] - [New Feature] Multilingual: Propagating existing associations if desired
- Fixed in Code Base
- 4 Aug 2018
- Medium
- Build: staging
- # 21321
- Diff
- infograf768:assoc_propagate
- Pending Hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #21250
Summary of Changes
This adds a "Propagate" button in the Associations tab when editing a contact, category, article, menu item, newsfeed.
This button will display when an association is selected in a Content Language field, offering the option to Propagate the associations defined for that item to the other Content Languages.
The button will display ONLY when there are more than 2 Content Languages defined for the site.
A message will display with the results obtained.
It is B/C as it will not break anything and one is totally free to choose or not to use the button, thus keeping the possibility to Clear/Select/Create any associations as before.
Using it prevents breaking existing associations when the wrong items are chosen for some fields.
A big thank you to Robbie Jackson for the long work to get this new functionality.
Target Milestone: 3.9.0
Testing Instructions
Create a Multilingual site with 3 or more languages.
Create items in each type: (contact, category, article, menu item, newsfeed) for 2 of these languages and associate them in each case.
Create a new item for each type, select another language than the ones which are already associated.
Save (NOT save and close) this item.
Display the Association tab.
You will see, as usual (here for 4 Content Languages)
I do have already associations set for English and French.
I select for English the item which I know is associated.
The button displays (Better tip welcome)
Clicking on the button will give
Result: the already associated category in French is added in the French field.
As we have no association set for Spanish, the field remains empty.
The message displays (it is the same in all cases except if there is an Ajax error)
All existing associations have been set. If some are missing you may have to select or create them manually.
If we have already associated all fields, clicking on Propagate will just display the message.
If we change an association in one of the fields and click Propagate, it is the associations from that language item that will be propagated and therefore replace the ones existing.
Documentation Changes Required
Yes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_categories com_contact com_content com_menus com_newsfeeds Language & Strings JavaScript |
| Labels |
Added:
?
?
|
||
Testing this and my only issue is with the messages
The propagate button says
Propagate this items existing associations
But you always get this message
All existing associations have been set. If some are missing you may have to select or create them manually.
The code should check to see if there any associations to propagate and if not then the message should be
No associations exist to propagate
And if there are associations to propagate then the message should be
All existing associations have been set.
We will now get 3 types of messages:
JGLOBAL_ASSOCIATIONS_PROPAGATE_MESSAGE_ALL="All existing associations have been set."
JGLOBAL_ASSOCIATIONS_PROPAGATE_MESSAGE_NONE="No associations exist to propagate."
JGLOBAL_ASSOCIATIONS_PROPAGATE_MESSAGE_SOME="Some associations have been set: %s"
JGLOBAL_ASSOCIATIONS_PROPAGATE_MESSAGE_SOME will also display the language(s) where associations have been added.
Example. Here I selected an article for English. It added the French existing association, but as the Spanish one did not exist, it is that message which is used displaying which association was set.
Restarted drone who failed on js.
Much better now.
I am also getting a missing string JGLOBAL_ASSOCIATIONS_PROPAGATE_TIP
done
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21321.
One more tester.
@Quy @franz-wohlkoenig @brianteeman
Please add your tests.
@infograf768 have read Instructions a few Times but didn't understand really what is to test. So i need Time.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21321.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
| Labels |
Added:
?
|
||
@dgrammatiko
Modified the new js functions name as required.
We can't obviously normalize the others as it would not be B/C.
@franz-wohlkoenig @jreys
Please test again. :)
| Status | Ready to Commit | ⇒ | Pending |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21321.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-08-04 15:29:51 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Removed:
?
|
||
Thanks.
the json files need corrections for cs. Can be tested and commented nevertheless. ;)