Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#21322] - [4.0][Atum] Add border for btn-outline-* Bootstrap classes

? Pending

User tests: Successful: Unsuccessful:

avatar ciar4n
ciar4n
31 Jul 2018

Pull Request for Issue #21302 .

Summary of Changes

Adds a border back to buttons fixing btn-outline-* classes

If these outline classes should exist is questionable however Bootstrap does not allow us to easily remove them.

Testing Instructions

Easiest test is to paste the following somewhere in to the backend using your browser web dev tools...

<button type="button" class="btn btn-outline-primary">Primary</button>
<button type="button" class="btn btn-outline-secondary">Secondary</button>
<button type="button" class="btn btn-outline-success">Success</button>
<button type="button" class="btn btn-outline-danger">Danger</button>
<button type="button" class="btn btn-outline-warning">Warning</button>
<button type="button" class="btn btn-outline-info">Info</button>
<button type="button" class="btn btn-outline-dark">Dark</button>

Before

image

After

image

Documentation Changes Required

avatar ciar4n ciar4n - open - 31 Jul 2018
avatar ciar4n ciar4n - change - 31 Jul 2018
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Jul 2018
Category ⇒ Administration Templates (admin)
avatar ciar4n ciar4n - change - 31 Jul 2018
Title
…
[4.0 Add border for btn-outline-* Bootstrap classes
[4.0][Atum] Add border for btn-outline-* Bootstrap classes
avatar ciar4n ciar4n - edited - 31 Jul 2018
avatar ciar4n ciar4n - change - 31 Jul 2018
Labels Added: ?
avatar ggppdk
ggppdk - comment - 31 Jul 2018

Tested it works
but template also forces white inside the toolbar for buttons
.subhead .btn {color: #fff;}

templates\atum\scss\blocks\_toolbar.scss

Can we change

// Toolbar

.subhead {
   ...

  .btn {
    ...
    color: #fff;
    ...
  }
}

to ?

// Toolbar

.subhead {
   ...

  .btn:not([class^="btn-outline-"]):not([class*="btn-outline-"]) {
    color: fff;
  }

  .btn {
    ...
    ...
  }
}
avatar ciar4n
ciar4n - comment - 31 Jul 2018

Pretty sure that .subhead .btn {color: #fff;} is not needed. Let me check...

avatar ciar4n
ciar4n - comment - 31 Jul 2018

.subhead .btn {color: #fff;} removed without any apparent issue.

avatar ggppdk ggppdk - test_item - 31 Jul 2018 - Tested successfully
avatar ggppdk
ggppdk - comment - 31 Jul 2018

I have tested this item ✅ successfully on 52aa1b0

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21322.

avatar wilsonge wilsonge - close - 31 Jul 2018
avatar wilsonge wilsonge - merge - 31 Jul 2018
avatar wilsonge wilsonge - change - 31 Jul 2018
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-07-31 11:09:13
Closed_By ⇒ wilsonge
avatar wilsonge
wilsonge - comment - 31 Jul 2018

Thanks!

Add a Comment

Login with GitHub to post a comment