J4 Issue ?
avatar Anu1601CS
Anu1601CS
17 Jul 2018

Steps to reproduce the issue

try to do a Joomla update.

For test you can use: https://www.jah-tz.de/downloads/core/gsoc18_override_management/gsoc18_update_list.xml

Expected result

Update successfully needs to be done!.

Actual result

Error : Invalid Ajax data.

screenshot from 2018-07-17 17-59-29

System information (as much as possible)

Linux

Additional comments

Maybe after this #21057
issue occurred.
@brianteeman @wilsonge @mbabker

avatar Anu1601CS Anu1601CS - open - 17 Jul 2018
avatar joomla-cms-bot joomla-cms-bot - change - 17 Jul 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 17 Jul 2018
avatar brianteeman
brianteeman - comment - 17 Jul 2018

possibly due to line 128 restore_finalisation.php

avatar franz-wohlkoenig franz-wohlkoenig - change - 17 Jul 2018
Status New Discussion
avatar franz-wohlkoenig franz-wohlkoenig - change - 17 Jul 2018
Category com_joomlaupdate
avatar mbabker
mbabker - comment - 17 Jul 2018

We're going to have to get tricky with this file. The intent is to overload the core classes, so as they're now namespaced, the overloading has to use the correct namespacing as well.

I think this is right (there are no IDE reported errors and no reported syntax errors linting the file), but I never write files using multiple namespaces, so I have no idea if this is going to do what we want it to.

https://gist.github.com/mbabker/5e171b1df99f71a30290125e0292b1d9

avatar astridx
astridx - comment - 18 Jul 2018

I can confirm this issue.

avatar brianteeman brianteeman - change - 18 Jul 2018
Labels Added: J4 Issue
avatar brianteeman brianteeman - labeled - 18 Jul 2018
avatar ReLater
ReLater - comment - 22 Jul 2018

@mbabker After adding the proposed file https://gist.github.com/mbabker/5e171b1df99f71a30290125e0292b1d9 to an update or full package (Nightly Builds) I could update via Upload&Update without any issues. AJAX error is gone.

avatar Anu1601CS
Anu1601CS - comment - 31 Jul 2018

@mbabker @brianteeman Any progress of this issue? How we have to deal with this file ?

avatar mbabker
mbabker - comment - 31 Jul 2018

If the comment from @ReLater is any indication of success, just need a pull request updating administrator/components/com_joomlaupdate/restore_finalisation.php with the contents of the gist.

avatar ReLater
ReLater - comment - 1 Aug 2018

See pr #21332

avatar joomla-cms-bot joomla-cms-bot - change - 1 Aug 2018
Closed_By franz-wohlkoenig joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 1 Aug 2018
avatar franz-wohlkoenig franz-wohlkoenig - change - 1 Aug 2018
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2018-08-01 03:49:05
Closed_By franz-wohlkoenig
avatar joomla-cms-bot
joomla-cms-bot - comment - 1 Aug 2018
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 1 Aug 2018

closed as having Pull Request #21332

Add a Comment

Login with GitHub to post a comment