? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
17 Jul 2018

Apply the text align on the body element - remove it from everywhere else. Check everything is still right aligned

avatar wilsonge wilsonge - open - 17 Jul 2018
avatar wilsonge wilsonge - change - 17 Jul 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Jul 2018
Category Administration Templates (admin)
avatar wilsonge wilsonge - change - 17 Jul 2018
The description was changed
avatar wilsonge wilsonge - edited - 17 Jul 2018
avatar wilsonge wilsonge - change - 18 Jul 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-07-18 19:46:44
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 18 Jul 2018
avatar wilsonge wilsonge - merge - 18 Jul 2018
avatar infograf768
infograf768 - comment - 20 Jul 2018

@wilsonge

There are still a few problems. My example here is the module edit page.
screen shot 2018-07-20 at 08 23 16

When modifying a class like
.control-group .control-label line 1649
with a float:right; instead of left, you are overriding only one aspect of the class loaded before.

We have line 391

  .control-group .control-label {
    float: left;
    width: 220px;
    padding-top: 5px;
    padding-right: 5px;
    text-align: left; }

Therefore, a text-align: right; has to be added in the overriding class.
Once corrected, we have
screen shot 2018-07-20 at 07 44 01

Also for .controls class line 1654
we should have
.control-group .controls {
margin-right: 0;
margin-left: 0;
}
NOTE: _this one will not work when editing Publishing in an article edit for the calendar field and select user field
we may need for that a new class in rtl

.field-calendar {
	float: right; }

and

.field-user-wrapper {
  float:right; }

Now looks better, but we still have some issues

  1. The text near the switcher is not placed correctly
    I.e. we need to modify /media/system/webcomponents/css/joomla-field-switcher.css
    Take off left: 10px;
    and change line 64 and before 84 to
  joomla-field-switcher .switcher-labels {
    position: relative; }
    joomla-field-switcher .switcher-labels span {
      position: absolute;
      top: 0;
      color: #868e96;
      visibility: hidden;
      opacity: 0;
      -webkit-transition: all .2s ease-in-out;
      transition: all .2s ease-in-out; }
      joomla-field-switcher .switcher-labels span.active {
        visibility: visible;
        opacity: 1;
        -webkit-transition: all .2s ease-in-out;
        transition: all .2s ease-in-out; }
      [dir="rtl"] joomla-field-switcher .switcher-labels span {
        right: 10px; }
      [dir="ltr"] joomla-field-switcher .switcher-labels span {
        left: 10px; }

We get
screen shot 2018-07-20 at 08 17 09

  1. Remains to take care of the tip
    We also need a new class for .form-text
    with a float:right; to override the class in bootstrap.css line 1430

and that page is now solved
screen shot 2018-07-20 at 08 21 36

These should solve the similar problems elsewhere in the template.

Sorry, I have no idea how to use sass and scss. A tuto for that would be nice.

avatar infograf768
infograf768 - comment - 20 Jul 2018

@wilsonge
Making PR now.

avatar infograf768
infograf768 - comment - 21 Jul 2018

Add a Comment

Login with GitHub to post a comment