[#21159] - Restrict processing of tab items to immediate children
- Closed
- 19 Oct 2019
- Medium
- Build: 4.0-dev
- # 21159
- Diff
- ryandemmer:patch-3
- Success Hound No violations found. Woof! Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Summary of Changes
When creating a new tabset within an existing tabset, using JHtml::_('bootstrap.startTabSet') etc., the tab items of the new tabset will be appended to the existing "parent" tabset.
This PR changes the selector for the jQuery iterator so that only the immediate "tab-pane" children of the tab content div are targeted and not all "tab-pane" nodes in the content div.
Testing Instructions
This is difficult to test without creating a new component or heavily editing an existing one, but the issue can be seen in markup like this:
<?php echo JHtml::_('bootstrap.startTabSet', 'tabs');?>
<?php echo JHtml::_('bootstrap.addTab', 'tabs', 'tabs-tab1', 'Tab1');?>
<div class="row-fluid">
<div class="tabbable tabs-left flex-column">
<?php echo JHtml::_('bootstrap.startTabSet', 'tabs-left1'); ?>
<?php echo JHtml::_('bootstrap.addTab', 'tabs-left1', 'tabs-left1-tab1', 'Left1');?>
<div class="row-fluid">
<?php echo $this->loadTemplate('some_template'); ?>
</div>
<?php echo JHtml::_('bootstrap.endTab');?>
<?php echo JHtml::_('bootstrap.endTabSet'); ?>
</div>
</div>
<?php echo JHtml::_('bootstrap.endTab');?>
<?php echo JHtml::_('bootstrap.endTabSet'); ?>Expected result
A new set of tabs is created inside the existing tabset.
Actual result
The "Left1" tab item is appended to the "tabs-tab1" set, below "Tab1"
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript |
| Labels |
Added:
?
|
||
These scripts don't appear to be available / used anymore. Closing.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-10-19 12:52:12 |
| Closed_By | ⇒ | ryandemmer |
@dgrammatiko is this still a problem in J4?