[#21150] - [4.0] [Validation] Fix backend menu items with role="menuitem" not placed inside element with role="menu"
- Fixed in Code Base
- 17 Jul 2018
- Medium
- Build: 4.0-dev
- # 21150
- Diff
- ggppdk:patch-66
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Backend menu items with role="menuitem" should be placed inside element with role="menubar" or role="menu"
Testing Instructions
- Code review
- Validate backend, no more errors like:
An element with “role=menuitem” must be contained in, or owned by, an element with “role=menubar” or “role=menu”
Expected result
No error about “role=menubar” or “role=menu” missing
Actual result
The above error
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration |
| Labels |
Added:
?
|
||
I knew it sounded familiar ;)
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21150.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21150.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21150.
This is a different version of the admin menu from the one discussed here:
Joomla 4 Admin menu
I am confused. The current version does not work well.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-07-17 05:45:05 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
?
|
||
@zwiastunsw when you think something is wrong, please open a new issue. Thanks.
this is correct but i thought we had already done this before