? ? Pending

User tests: Successful: Unsuccessful:

avatar ggppdk
ggppdk
16 Jul 2018

Pull Request for Issue # .

Summary of Changes

Backend menu items with role="menuitem" should be placed inside element with role="menubar" or role="menu"

Testing Instructions

  1. Code review
  2. Validate backend, no more errors like:

An element with “role=menuitem” must be contained in, or owned by, an element with “role=menubar” or “role=menu”

Expected result

No error about “role=menubar” or “role=menu” missing

Actual result

The above error

Documentation Changes Required

None

avatar ggppdk ggppdk - open - 16 Jul 2018
avatar ggppdk ggppdk - change - 16 Jul 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Jul 2018
Category Modules Administration
avatar ggppdk ggppdk - change - 16 Jul 2018
Labels Added: ?
avatar brianteeman
brianteeman - comment - 16 Jul 2018

this is correct but i thought we had already done this before

avatar ggppdk
ggppdk - comment - 16 Jul 2018

There is an older issue about this
#19763

maybe this was meant to be done in a PR together with more accessibility changes

avatar brianteeman
brianteeman - comment - 16 Jul 2018

I knew it sounded familiar ;)

avatar brianteeman
brianteeman - comment - 16 Jul 2018

I have tested this item successfully on e17d4f5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21150.

avatar brianteeman brianteeman - test_item - 16 Jul 2018 - Tested successfully
avatar Quy Quy - test_item - 16 Jul 2018 - Tested successfully
avatar Quy
Quy - comment - 16 Jul 2018

I have tested this item successfully on e17d4f5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21150.

avatar Quy Quy - change - 16 Jul 2018
Status Pending Ready to Commit
avatar Quy
Quy - comment - 16 Jul 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21150.

avatar zwiastunsw
zwiastunsw - comment - 17 Jul 2018

This is a different version of the admin menu from the one discussed here:
Joomla 4 Admin menu
I am confused. The current version does not work well.

avatar laoneo laoneo - change - 17 Jul 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-07-17 05:45:05
Closed_By laoneo
Labels Added: ?
avatar laoneo laoneo - close - 17 Jul 2018
avatar laoneo laoneo - merge - 17 Jul 2018
avatar laoneo
laoneo - comment - 17 Jul 2018

@zwiastunsw when you think something is wrong, please open a new issue. Thanks.

Add a Comment

Login with GitHub to post a comment