Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#21149] - [4.0] Fix HTML of multilanguage status modal placed outside directly under

? ? Pending

User tests: Successful: Unsuccessful:

avatar ggppdk
ggppdk
16 Jul 2018

Pull Request for Issue # .

Summary of Changes

Move to the bottom of the template file of the admin module for multilanguage status modal link

Testing Instructions

  1. Code review, modal contents now placed inside <li></li>
  2. Click on multi-language status link at the top right, the modal with multi language status open as before the PR

Expected result

modal contents of multilanguage status admin module placed inside <li></li>

Actual result

modal contents of multilanguage status admin module placed directly under <ul>

Documentation Changes Required

None

avatar ggppdk ggppdk - open - 16 Jul 2018
avatar ggppdk ggppdk - change - 16 Jul 2018
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Jul 2018
Category ⇒ Modules Administration
avatar brianteeman
brianteeman - comment - 16 Jul 2018

Not sure i understand what the reason for this change is

avatar mbabker
mbabker - comment - 16 Jul 2018

Basically instead of this:

<ul>
    <li id="nav-item"></li>
    <div id="lang-modal"></div>
</ul>

It looks a little more like this:

<ul>
    <li id="nav-item">
        <div id="lang-modal"></div>
    </li>
</ul>

Per https://developer.mozilla.org/en-US/docs/Web/HTML/Element/ul a <div> isn't allowed to be a direct descendent of <ul>.

avatar brianteeman
brianteeman - comment - 16 Jul 2018

Per https://developer.mozilla.org/en-US/docs/Web/HTML/Element/ul a

isn't allowed to be a direct descendent of
    .

Thanks - that was the info I wanted :)

avatar brianteeman
brianteeman - comment - 16 Jul 2018

I have tested this item ✅ successfully on 18c1e54

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21149.

avatar brianteeman brianteeman - test_item - 16 Jul 2018 - Tested successfully
avatar Quy Quy - test_item - 16 Jul 2018 - Tested successfully
avatar Quy
Quy - comment - 16 Jul 2018

I have tested this item ✅ successfully on 18c1e54

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21149.

avatar Quy
Quy - comment - 16 Jul 2018

I have tested this item ✅ successfully on 18c1e54

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21149.

avatar Quy Quy - change - 16 Jul 2018
Title
…
Fix HTML of multilanguage status modal placed outside <li> directly under <ul>
[4.0] Fix HTML of multilanguage status modal placed outside directly under
Status Pending ⇒ Ready to Commit
avatar joomla-cms-bot joomla-cms-bot - edited - 16 Jul 2018
avatar Quy
Quy - comment - 16 Jul 2018

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21149.

avatar laoneo laoneo - change - 17 Jul 2018
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-07-17 05:47:04
Closed_By ⇒ laoneo
Labels Added: ? ?
avatar laoneo laoneo - close - 17 Jul 2018
avatar laoneo laoneo - merge - 17 Jul 2018

Add a Comment

Login with GitHub to post a comment