Feeling Lucky
?
[#21151] - The JPATH_ constants are not magic strings
- Fixed in Code Base
- 19 Jul 2018
- Medium
- Build: staging
- # 21151
- Diff
- mbabker:jpath-is-not-a-string
User tests: Successful: Unsuccessful:
Summary of Changes
Apparently it was intended for the admin com_contact contact view to import fields from the admin com_users component. This has never worked because the JPATH_ADMINISTRATOR constant has been referenced as a string instead of a constant. I honestly have no idea if the call is even needed, but the code is so obviously broken.
Testing Instructions
Review the code. If you're brave, wire up a debugger to check the contents of Joomla\CMS\Form\FormHelper::$paths before and after the patch on the contact edit page.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_contact |
alikon
- comment
- 19 Jul 2018
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21151.
| Status | Pending | ⇒ | Ready to Commit |
franz-wohlkoenig
- comment
- 19 Jul 2018
Ready to Commit after two successful tests.
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-07-19 12:19:08 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on b99e42e
Code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21151.