? Pending

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
16 Jul 2018

Summary of Changes

Apparently it was intended for the admin com_contact contact view to import fields from the admin com_users component. This has never worked because the JPATH_ADMINISTRATOR constant has been referenced as a string instead of a constant. I honestly have no idea if the call is even needed, but the code is so obviously broken.

Testing Instructions

Review the code. If you're brave, wire up a debugger to check the contents of Joomla\CMS\Form\FormHelper::$paths before and after the patch on the contact edit page.

avatar mbabker mbabker - open - 16 Jul 2018
avatar mbabker mbabker - change - 16 Jul 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Jul 2018
Category Administration com_contact
avatar Quy
Quy - comment - 17 Jul 2018

I have tested this item successfully on b99e42e

Code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21151.

avatar Quy Quy - test_item - 17 Jul 2018 - Tested successfully
avatar alikon alikon - test_item - 19 Jul 2018 - Tested successfully
avatar alikon
alikon - comment - 19 Jul 2018

I have tested this item successfully on b99e42e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21151.

avatar franz-wohlkoenig franz-wohlkoenig - change - 19 Jul 2018
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 19 Jul 2018

Ready to Commit after two successful tests.

avatar wilsonge wilsonge - change - 19 Jul 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-07-19 12:19:08
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 19 Jul 2018
avatar wilsonge wilsonge - merge - 19 Jul 2018

Add a Comment

Login with GitHub to post a comment