?
avatar brianteeman
brianteeman
4 Jul 2018

View the source and you will see that all the menu items have target=""
That is invalid markup

I am assuming the error is in this code block but I don't really understand it to fix


if ($link !== null && $current->get('target') !== null)
{
	echo "<a" . $linkClass . $dataToggle . " href=\"" . $link . "\" target=\"" . $current->get('target') . "\">" 
		. $iconClass
		. '<span class="sidebar-item-title">' . Text::_($current->get('title')) . "</span></a>";
}
elseif ($link !== null && $current->get('target') === null)
{
	echo "<a" . $linkClass . $dataToggle . " href=\"" . $link . "\">"
		. $iconClass
		. '<span class="sidebar-item-title" >' . Text::_($current->get('title')) . "</span></a>";
}
elseif ($current->get('title') !== null && $current->get('class') !== 'separator')
{
	echo "<a" . $linkClass . $dataToggle . ">"
		. $iconClass
		. '<span class="sidebar-item-title" >' . Text::_($current->get('title')) . "</span></a>";
}
else
avatar brianteeman brianteeman - open - 4 Jul 2018
avatar joomla-cms-bot joomla-cms-bot - change - 4 Jul 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 4 Jul 2018
avatar SharkyKZ
SharkyKZ - comment - 4 Jul 2018

Test PR #20976 please.

avatar joomla-cms-bot joomla-cms-bot - change - 4 Jul 2018
Status New Closed
Closed_Date 0000-00-00 00:00:00 2018-07-04 14:45:13
Closed_By joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 4 Jul 2018
avatar joomla-cms-bot
joomla-cms-bot - comment - 4 Jul 2018

Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/20975

avatar Quy Quy - change - 4 Jul 2018
Closed_Date 2018-07-04 14:45:13 2018-07-04 14:45:15
Closed_By joomla-cms-bot Quy

Add a Comment

Login with GitHub to post a comment