What help do you need in that layout?

line 43. i dont understand that code enough to make the required change

So that is trying to do a weird check if the input field is required by checking for the aria-required="true" in the input string or if there is a class required in the input string. Given the thing can't have an aria-attribute anymore you're safe to remove that check - but I don't know if we have required class either anymore or if we've just left it to the attribute - if it's now the required attribute then we're going to need to replace that check (can be validated in the frontend by seeing if that optional string is showing)

@wilsonge I can not even see where that is used

@brianteeman is right if the required attribute is used, then the aria-required attribute is redundant (This article refers to the role attributes, but today the screen readers, NVDA and JAWS certainly announce the required attribute, so no additional aria is needed).

Here are vardumps:

$match[1]:
string(21) "form-control required"

$input:

<input
		type="text"
		name="jform[contact_name]"
		id="jform_contact_name"
		value=""
				class="form-control required" size="30"        required      >

so this change should work:
$required = !empty($match[1]) && strpos($match[1], 'required') !== false;

@Quy @wilsonge I dont like removing any code unless i can see what its doing (or not)
I would assume that this code was adding the aria attribute but its not. In which case what is the code doing - if anything at all

The code appends (optional) to the label when not required.

Create a mail custom field with/without required attribute.
On the frontend, load a contact form page.

@Quy thanks I hadnt looked at custom fields. However it still never added the aria required ??

Without PR, aria-required="true" is present.

<input
		type="text"
		name="jform[contact_name]"
		id="jform_contact_name"
		value=""
				class="form-control required" size="30"        required aria-required="true"      >

With PR, no aria-required="true", therefore, it should be safe to remove strpos($input, 'aria-required="true"') !== false check.

<input
		type="text"
		name="jform[contact_name]"
		id="jform_contact_name"
		value=""
				class="form-control required" size="30"        required      

I have tested this item ✅ successfully on 5510c5e

Can we get one more test please so this can be merged

I have tested this item ✅ successfully on 592b80f

Ready to Commit after successful tests.

Thanks!

Thanks